From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28824: 26.0.90; display of pbm images broken? Date: Sat, 14 Oct 2017 22:16:37 +0300 Message-ID: <83376lilpm.fsf@gnu.org> References: <29226.45866.855134.23009@gargle.gargle.HOWL> <83376mjjq7.fsf@gnu.org> <86po9p93jz.fsf@gmail.com> <83d15piw5l.fsf@gnu.org> <86lgkd8uj8.fsf@gmail.com> <86h8v18scg.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1508008709 16905 195.159.176.226 (14 Oct 2017 19:18:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 19:18:29 +0000 (UTC) Cc: 28824@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 14 21:18:25 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Rwi-0001Bq-4o for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 21:18:04 +0200 Original-Received: from localhost ([::1]:55001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Rwp-0001o0-9Z for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 15:18:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Rwj-0001nk-1a for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 15:18:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3Rwf-0004kN-SS for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 15:18:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3Rwf-0004kJ-Oa for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 15:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3Rwf-0001N1-Ix for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 15:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28824-submit@debbugs.gnu.org id=B28824.15080086255188 (code B ref 28824); Sat, 14 Oct 2017 19:18:01 +0000 Original-Received: (at 28824) by debbugs.gnu.org; 14 Oct 2017 19:17:05 +0000 Original-Received: from localhost ([127.0.0.1]:40537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Rvj-0001La-Ck for submit@debbugs.gnu.org; Sat, 14 Oct 2017 15:17:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Rvi-0001L4-6s for 28824@debbugs.gnu.org; Sat, 14 Oct 2017 15:17:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3Rva-0004Wh-1P for 28824@debbugs.gnu.org; Sat, 14 Oct 2017 15:16:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3RvZ-0004Wc-UC; Sat, 14 Oct 2017 15:16:53 -0400 Original-Received: from [176.228.60.248] (port=4026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e3RvY-0000Vp-0o; Sat, 14 Oct 2017 15:16:53 -0400 In-reply-to: <86h8v18scg.fsf@gmail.com> (message from Andy Moreton on Sat, 14 Oct 2017 20:03:27 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138417 Archived-At: > From: Andy Moreton > Date: Sat, 14 Oct 2017 20:03:27 +0100 > > Further testing with the images from etc/images in emacs 26 shows that > this patch appears to fix the problem: > > diff --git a/lisp/image.el b/lisp/image.el > index 1d0776180b..32df508bc8 100644 > --- a/lisp/image.el > +++ b/lisp/image.el > @@ -34,8 +34,8 @@ 'image-refresh > (defconst image-type-header-regexps > `(("\\`/[\t\n\r ]*\\*.*XPM.\\*/" . xpm) > ("\\`P[1-6]\\(?:\ > -\\(?:\\(?:#[^\r\n]*[\r\n]\\)?[[:space:]]\\)+\ > -\\(?:\\(?:#[^\r\n]*[\r\n]\\)?[0-9]\\)+\ > +\\(?:\\(?:#[^\r\n]*[\r\n]\\)*[[:space:]]\\)+\ > +\\(?:\\(?:#[^\r\n]*[\r\n]\\)*[0-9]\\)+\ > \\)\\{2\\}" . pbm) > ("\\`GIF8[79]a" . gif) > ("\\`\x89PNG\r\n\x1a\n" . png) Thanks. However, I'm puzzled by the fact that it works here without any changes. Can you step with a debugger through the code in image.c and tell what exactly fails with the unmodified regexp?