From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Sun, 21 Jan 2018 17:53:28 +0200 Message-ID: <83372zryx3.fsf@gnu.org> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> <83bmhpt12i.fsf@gnu.org> <867escw93p.fsf@phe.ftfl.ca> <86vafwumqp.fsf@phe.ftfl.ca> <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516549941 12805 195.159.176.226 (21 Jan 2018 15:52:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Jan 2018 15:52:21 +0000 (UTC) Cc: jrm@ftfl.ca, ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 21 16:52:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edHuR-0001x1-Dz for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2018 16:51:51 +0100 Original-Received: from localhost ([::1]:34647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edHwR-0003FG-QH for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2018 10:53:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edHwL-0003F2-6j for emacs-devel@gnu.org; Sun, 21 Jan 2018 10:53:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edHwH-0006CO-2z for emacs-devel@gnu.org; Sun, 21 Jan 2018 10:53:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edHwG-0006CI-VX; Sun, 21 Jan 2018 10:53:45 -0500 Original-Received: from [176.228.60.248] (port=2124 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1edHwG-0000gX-Ba; Sun, 21 Jan 2018 10:53:44 -0500 In-reply-to: <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> (message from Paul Eggert on Sat, 20 Jan 2018 19:41:32 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222124 Archived-At: > Cc: ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org > From: Paul Eggert > Date: Sat, 20 Jan 2018 19:41:32 -0800 > > Joseph Mingrone wrote: > > the problem only seems to occur when /tmp supports ACLs, > > but $WRKDIR (location where the tarball is extracted and the build > > occurs) does not. > > The problem occurs because (rename-file A B) signals an error if A has ACLs and > B's file system does not support ACLs. This is because rename-file calls > (copy-file A B nil t t t) and that last "t" tells copy-file to copy ACLs. Why doesn't copy-file (or qcopy_acl?) use acl_errno_valid, as we do in set-file-acl? Is there a reason for this inconsistency?