From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Accept plists when serializing and parsing JSON
Date: Sat, 02 Jun 2018 09:55:21 +0300 [thread overview]
Message-ID: <8336y5fzja.fsf@gnu.org> (raw)
In-Reply-To: <87d0xaozl1.fsf@gmail.com> (message from João Távora on Sat, 02 Jun 2018 00:29:30 +0100)
> From: João Távora <joaotavora@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 02 Jun 2018 00:29:30 +0100
>
> > Here I'd use intern_1 instead, it would allow you to avoid
> > unnecessarily consing Lisp objects. (Yes, I realize that the same
> > comment applies to the existing code.)
>
> Riight, intern_1 sounds good... I know I can't just malloc() stuff as
> usually right? But also, I have no idea what I'm doing, I aped this from
> somewhere where it looked more-or-less responsibly done.
>
> json_object_foreach (json, key_str, value)
> {
> USE_SAFE_ALLOCA;
> char *keyword_key_str = SAFE_ALLOCA (1 + strlen(key_str) + 1);
> keyword_key_str[0]=':';
> strcpy(&keyword_key_str[1],key_str);
> Lisp_Object key = intern_1(keyword_key_str, strlen(key_str)+1);
> result = Fcons (key, result); /* build the plist as
> value-key since
> we're going to
> reverse it in the
> end.*/
> result = Fcons (json_to_lisp (value, object_type), result);
> SAFE_FREE ();
> }
This looks OK to me, modulo a few stylistic gotchas:
. use a temporary variable to compute strlen only once
. leave one space _before_ an opening paren and around binary
operators such as '+' and ',', as in, for example,
intern_1 (keyword_key_str, strlen (key_str) + 1);
^ ^ ^ ^
. I personally prefer
strcpy (keyword_key_str + 1, ...
to
strcpy (&keyword_key_str[1], ...
although both do the same and are correct C
. It is preferable to have long comments before the code, not at its
side, split between several lines; and make the comment start with
a capital letter, since it's a full sentence
next prev parent reply other threads:[~2018-06-02 6:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 14:59 [PATCH] Accept plists when serializing and parsing JSON João Távora
2018-05-29 21:20 ` Philipp Stephani
2018-05-29 22:03 ` João Távora
2018-05-30 6:37 ` Yuri Khan
2018-05-30 8:58 ` João Távora
2018-06-02 8:04 ` Philipp Stephani
2018-06-03 0:34 ` João Távora
2018-06-03 4:05 ` Stefan Monnier
2018-06-03 13:43 ` João Távora
2018-06-02 7:45 ` Philipp Stephani
2018-06-02 7:39 ` Philipp Stephani
2018-06-01 9:39 ` Eli Zaretskii
2018-06-01 23:29 ` João Távora
2018-06-02 6:55 ` Eli Zaretskii [this message]
2018-06-02 8:24 ` Philipp Stephani
2018-06-02 9:00 ` Eli Zaretskii
2018-06-02 16:46 ` Philipp Stephani
2018-06-02 19:18 ` Eli Zaretskii
2018-06-08 14:45 ` Eli Zaretskii
2018-06-02 8:30 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336y5fzja.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.