From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Fri, 14 Dec 2018 12:03:32 +0200 Message-ID: <8336r0h1cb.fsf@gnu.org> References: <20181213203102.GF2244@macbook.localdomain> <83h8fghcpo.fsf@gnu.org> <20181214075056.GI2244@macbook.localdomain> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1544781738 32365 195.159.176.226 (14 Dec 2018 10:02:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2018 10:02:18 +0000 (UTC) Cc: behdad@behdad.org, kaushal.modi@gmail.com, 33729@debbugs.gnu.org, far.nasiri.m@gmail.com To: Khaled Hosny Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 14 11:02:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXkIP-0008Jp-Ih for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 11:02:13 +0100 Original-Received: from localhost ([::1]:60627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXkKW-0000nl-EE for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 05:04:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXkKE-0000ka-MB for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 05:04:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXkKA-0006Az-M7 for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 05:04:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXkKA-0006Ao-ID for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 05:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gXkKA-0007tQ-Cb for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 05:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Dec 2018 10:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.154478182930304 (code B ref 33729); Fri, 14 Dec 2018 10:04:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 14 Dec 2018 10:03:49 +0000 Original-Received: from localhost ([127.0.0.1]:47337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXkJx-0007si-2S for submit@debbugs.gnu.org; Fri, 14 Dec 2018 05:03:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXkJv-0007sX-5v for 33729@debbugs.gnu.org; Fri, 14 Dec 2018 05:03:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXkJo-0005zO-Sx for 33729@debbugs.gnu.org; Fri, 14 Dec 2018 05:03:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXkJj-0005vJ-QU; Fri, 14 Dec 2018 05:03:35 -0500 Original-Received: from [176.228.60.248] (port=3980 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gXkJj-0007bb-Cu; Fri, 14 Dec 2018 05:03:35 -0500 In-reply-to: <20181214075056.GI2244@macbook.localdomain> (message from Khaled Hosny on Fri, 14 Dec 2018 09:50:56 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153445 Archived-At: > Date: Fri, 14 Dec 2018 09:50:56 +0200 > From: Khaled Hosny > Cc: Kaushal Modi , behdad@behdad.org, > 33729@debbugs.gnu.org, far.nasiri.m@gmail.com > > > Your data indicates that the m17n build performs character composition > > at buffer position 34, whereas the harfbuzz build does not. The > > question is why. > > See my earlier email, most likely the culprit is the broken Emacs to > HarfBuzz script code mapping that we discussed earlier. HarfBuzz needs > to know the correct script of the text to perform shaping, and it looks > like we are passing nonsense values for certain scripts (or rather for > certain scripts we are lucky that the mapping is not broken). Thanks. I don't yet have access to a GNU/Linux system with HarfBuzz installed, so I cannot myself debug it. I hope Mohammad will be able to look into this and either fix it or provide more focused and detailed analysis of what is wrong, so we could fix it. Or maybe you could point to the problematic code and tell more details. FWIW, I looked at ftfont.c:uni_script, and I cannot find a problem with it; in particular looking up in char-script-table each character of the Gujarati welcome in HELLO yields 'gujarati', so I couldn't see any evident Emacs issue. Or are you saying that hb_script_from_string doesn't DTRT? Or maybe Kaushal should upgrade to a newer version of HarfBuzz? Thanks.