From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) Date: Mon, 17 Dec 2018 21:58:26 +0200 Message-ID: <8336qwdixp.fsf@gnu.org> References: <20181217192011.17783-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1545076641 6545 195.159.176.226 (17 Dec 2018 19:57:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 19:57:21 +0000 (UTC) Cc: phst@google.com, 28691@debbugs.gnu.org, michael.albinus@gmx.de To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 17 20:57:17 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYz0r-0001Vl-H3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 20:57:13 +0100 Original-Received: from localhost ([::1]:49317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYz2y-0003hO-DG for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 14:59:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYz2o-0003gl-57 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:59:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYz2d-0006Ky-NU for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:59:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYz2c-0006KI-EO for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYz2c-0000nB-BB for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2018 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28691-submit@debbugs.gnu.org id=B28691.15450767293024 (code B ref 28691); Mon, 17 Dec 2018 19:59:02 +0000 Original-Received: (at 28691) by debbugs.gnu.org; 17 Dec 2018 19:58:49 +0000 Original-Received: from localhost ([127.0.0.1]:52269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYz2P-0000mi-B3 for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:58:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYz2O-0000mW-62 for 28691@debbugs.gnu.org; Mon, 17 Dec 2018 14:58:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYz2H-00069L-V2 for 28691@debbugs.gnu.org; Mon, 17 Dec 2018 14:58:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYz26-00062L-F0; Mon, 17 Dec 2018 14:58:32 -0500 Original-Received: from [176.228.60.248] (port=3282 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gYz20-0006rT-40; Mon, 17 Dec 2018 14:58:25 -0500 In-reply-to: <20181217192011.17783-1-phst@google.com> (message from Philipp Stephani on Mon, 17 Dec 2018 20:20:11 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153533 Archived-At: > From: Philipp Stephani > Date: Mon, 17 Dec 2018 20:20:11 +0100 > Cc: Philipp Stephani > > +@item :file-handler @var{file-handler} > +If @var{file-handler} is non-@code{nil}, then look for a file name > +handler for the current buffer's @code{default-directory} ... and invoke that file handler to make the process. > + If there > +is no such handler, proceed as if @var{file-handler} were nil. ^^^ That "nil" should be in @code. > +** 'make-process' now takes a keyword argument ':file-handler'; if > +that is non-nil, it will look for a file name handler for the current > +buffer's 'default-directory'. Likewise. > +:file-handler FILE-HANDLER -- If FILE-HANDLER is non-nil, then look > +for a file name handler for the current buffer's `default-directory'. Likewise. > + (skip-unless (file-accessible-directory-p "/:/bin/")) I don't see why we should skip important tests on platforms where there's no /bin. Isn't it possible to use the Emacs binary here (and elsewhere in the tests you add), as I suggested? Thanks.