From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34513: display-line-numbers in term mode Date: Wed, 27 Feb 2019 19:06:02 +0200 Message-ID: <8336o9kvph.fsf@gnu.org> References: <20190217141940.62v754v46qwfcs2i@Ergus> <83h8cpkyi8.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180944"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34513@debbugs.gnu.org, spacibba@aol.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 27 18:07:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gz2fr-000kwC-KN for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 18:07:15 +0100 Original-Received: from localhost ([127.0.0.1]:47692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz2fq-0005yV-K6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 12:07:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz2fj-0005yB-II for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:07:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gz2fi-0003kw-TF for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:07:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40726) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gz2fe-0003j2-5O for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:07:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gz2fd-0005Fu-T4 for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Feb 2019 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34513 X-GNU-PR-Package: emacs Original-Received: via spool by 34513-submit@debbugs.gnu.org id=B34513.155128717620144 (code B ref 34513); Wed, 27 Feb 2019 17:07:01 +0000 Original-Received: (at 34513) by debbugs.gnu.org; 27 Feb 2019 17:06:16 +0000 Original-Received: from localhost ([127.0.0.1]:54270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz2et-0005Eq-J1 for submit@debbugs.gnu.org; Wed, 27 Feb 2019 12:06:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz2es-0005Ec-BL for 34513@debbugs.gnu.org; Wed, 27 Feb 2019 12:06:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz2eW-0003Jc-BH; Wed, 27 Feb 2019 12:05:54 -0500 Original-Received: from [176.228.60.248] (port=4445 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gz2eR-0002D2-FM; Wed, 27 Feb 2019 12:05:51 -0500 In-reply-to: (message from Stefan Monnier on Wed, 27 Feb 2019 11:40:04 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155858 Archived-At: > From: Stefan Monnier > Cc: spacibba@aol.com, 34513@debbugs.gnu.org > Date: Wed, 27 Feb 2019 11:40:04 -0500 > > How 'bout display-line-numbers-width or display-line-numbers-current-width? I think I considered those at the time, but found them not descriptive enough. And please remember that originally the code was entirely in C, so there was no "package name" to use as prefix. display-line-numbers.el and display-line-numbers-mode were born much later. > >> - (ncols (/ window-width font-width))) > >> + (ncols (- (/ window-width font-width) (line-number-display-width)))) > > I think you want (line-number-display-width 'columns), since this > > wants the canonical column units, right? > > Could be, I don't know. I don't know that all callers of > window-max-chars-per-line want that either. I hope someone does know.