From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 Date: Sun, 05 May 2019 19:00:09 +0300 Message-ID: <8336lslwmu.fsf@gnu.org> References: <877ebeor2d.fsf@gmail.com> <83tveit5ph.fsf@gnu.org> <87pnp5oqu1.fsf@gmail.com> <877ebcogg4.fsf@gmail.com> <83sgu0rsue.fsf@gnu.org> <8736lznzjf.fsf@gmail.com> <83zho6ox5u.fsf@gnu.org> <878svomynv.fsf@gmail.com> <838svmmy5q.fsf@gnu.org> <87pnoyj9wh.fsf@gmail.com> <1f69e048f5d28aeab38a2e21320e3f26.squirrel@weber.math.s.chiba-u.ac.jp> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185961"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35468@debbugs.gnu.org, agrambot@gmail.com To: mituharu@math.s.chiba-u.ac.jp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 05 18:07:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hNJfM-000mEv-4o for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 May 2019 18:07:04 +0200 Original-Received: from localhost ([127.0.0.1]:43203 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNJfL-0003HU-5K for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 May 2019 12:07:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNJZX-0007hL-8j for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 12:01:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNJZW-00023c-8u for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 12:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNJZW-00023R-5a for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 12:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hNJZW-0008Mq-3X for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 12:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2019 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35468-submit@debbugs.gnu.org id=B35468.155707203732127 (code B ref 35468); Sun, 05 May 2019 16:01:02 +0000 Original-Received: (at 35468) by debbugs.gnu.org; 5 May 2019 16:00:37 +0000 Original-Received: from localhost ([127.0.0.1]:54716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNJZ7-0008M7-Gh for submit@debbugs.gnu.org; Sun, 05 May 2019 12:00:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNJZ4-0008Lu-KL for 35468@debbugs.gnu.org; Sun, 05 May 2019 12:00:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNJYy-0001gk-VX; Sun, 05 May 2019 12:00:29 -0400 Original-Received: from [176.228.60.248] (port=2224 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hNJYy-0004UE-1X; Sun, 05 May 2019 12:00:28 -0400 In-reply-to: <1f69e048f5d28aeab38a2e21320e3f26.squirrel@weber.math.s.chiba-u.ac.jp> (mituharu@math.s.chiba-u.ac.jp) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158799 Archived-At: > Date: Sun, 5 May 2019 09:10:38 +0900 > From: mituharu@math.s.chiba-u.ac.jp > Cc: "Eli Zaretskii" , > 35468@debbugs.gnu.org > > >> And what does glyph_image_uses_mask hide? AFAIU, the current code > >> simply looks at s->img->mask, and if so, why do we need an interface > >> for that? > > > > I was thinking that since AFAIU the Cairo drawing doesn't set > > s->img->mask it wouldn't make sense, from an interface POV, to check it > > directly. I suppose it doesn't really matter in that case, and it would > > be faster to just check s->img->mask even if the backend doesn't use it. > > IMO, image support for cairo is still premature and needs some > restructuring. It does not support postprocessing (:conversion > ALGORITHM), mask removal (:mask nil), or image-mask-p. Bitmaps > for some image format are not stored in the premultiplied alpha > format that cairo expects. > > All of them are supported in the Mac port and I set dummy > s->img->mask there (not containing the actual mask bitmap data) > if the image has an alpha channel. Probably setting a bitfield > for the existence of mask (alpha channel) when creating image > data would work as an alternative way. Would you like to propose the abstractions for this that are supposed to be future-proof (if what Alex shows isn't already sufficiently so)? TIA