From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: package.el encoding problem
Date: Sat, 25 May 2019 19:03:30 +0300 [thread overview]
Message-ID: <8336l24j3h.fsf@gnu.org> (raw)
In-Reply-To: <jwv8suutvbe.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 25 May 2019 11:26:21 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 25 May 2019 11:26:21 -0400
>
> > You previously said that in the past we attempted to bind
> > coding-system-for-write, which in general is the easiest way of
> > preventing the prompt. Didn't it work?
>
> For some reason this function does something else:
>
> (defun package--write-file-no-coding (file-name)
> (let ((buffer-file-coding-system 'no-conversion))
> (write-region (point-min) (point-max) file-name nil 'silent)))
>
> AFAIK using coding-system-for-write would have solve the problem as well.
Yes. In fact, binding buffer-file-coding-system is not useful at all.
So why not bind coding-system-for-write here?
> > One obvious benefit is that you won't need to set the buffer to be
> > unibyte.
>
> (set-buffer-multibyte nil) sets up the buffer to receive bytes.
> Since we're putting bytes into the buffer, it's The Right Thing to do.
We disagree here. We can put bytes into a multibyte buffer, they have
a special representation there which tells they are raw bytes, so
there's nothing wrong with doing that.
> > People tend to regard this as some kind of black magic, which creates
> > myths, like the (wrong) idea that unibyte text cannot be processed
> > correctly in a multibyte buffer.
>
> I think they're right: it's hard to get it right.
Using a multibyte buffer removes one subtlety from what we should
educate people to do in this case, so it's easier to get that right.
> Don't get me wrong: it's important that it be possible to do it, because
> that's sometimes necessary. But when the code only manipulates bytes,
> using any multibyte objects along the way is asking for trouble.
Sorry, I see no trouble here. the only trouble is the binding of
buffer-file-coding-system instead of coding-system-for-write.
prev parent reply other threads:[~2019-05-25 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 15:18 package.el encoding problem Yuri D'Elia
2019-05-23 15:27 ` Noam Postavsky
2019-05-23 15:33 ` Yuri D'Elia
2019-05-24 15:45 ` Stefan Monnier
2019-05-24 16:36 ` Stefan Monnier
2019-05-25 6:43 ` Eli Zaretskii
2019-05-25 12:15 ` Stefan Monnier
2019-05-25 13:47 ` Eli Zaretskii
2019-05-25 14:55 ` Stefan Monnier
2019-05-25 15:03 ` Eli Zaretskii
2019-05-25 15:26 ` Stefan Monnier
2019-05-25 16:03 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336l24j3h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.