From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [w32] Build failure on master (pthread_sigmask.h) Date: Thu, 30 May 2019 21:44:01 +0300 Message-ID: <8336kvye8e.fsf@gnu.org> References: <837ea8xc88.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="252386"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Richard Copley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 30 20:44:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWQ24-0013XO-0J for ged-emacs-devel@m.gmane.org; Thu, 30 May 2019 20:44:08 +0200 Original-Received: from localhost ([127.0.0.1]:57809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWQ22-0001cY-Ux for ged-emacs-devel@m.gmane.org; Thu, 30 May 2019 14:44:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWQ1u-0001b6-Eg for emacs-devel@gnu.org; Thu, 30 May 2019 14:43:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWQ1p-0000bS-7A; Thu, 30 May 2019 14:43:55 -0400 Original-Received: from [176.228.60.248] (port=2744 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hWQ1n-0003yV-1g; Thu, 30 May 2019 14:43:51 -0400 In-reply-to: (message from Richard Copley on Thu, 30 May 2019 16:54:13 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237172 Archived-At: > From: Richard Copley > Date: Thu, 30 May 2019 16:54:13 +0100 > Cc: Emacs Development > > > gcc -c -mtune=generic -DUSE_CRT_DLL=1 -I /c/projects/emacs/nt/inc -mtune=generic -MMD -MF > > deps/pthread_sigmask.d -MP -fno-common -O2 -I. -I../src -I. -I./../src pthread_sigmask.c > > In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/signal.h:10, > > from pthread_sigmask.c:20: > > pthread_sigmask.c:34:1: error: expected identifier or '(' before numeric constant > > 34 | pthread_sigmask (int how, const sigset_t *new_mask, sigset_t *old_mask) > > | ^~~~~~~~~~~~~~~ > > This doesn't happen to me, but I don't use MinGW64. > > Can you spot the part of the changes which caused us to include > pthread_signal.h? We shouldn't include any part of pthreads in the > Windows build. > > Not beyond the obvious (it's the pthread_sigmask.m4 changes), no. Sorry. > Prior to this change, lib\pthread_sigmask.c wasn't compiled at all AFAICS. We need to augment nt/mingw-cfg.site to bypass pthread_sigmask, there are already some settings there to that effect, we need to adapt them to this Gnulib change. Maybe try adding this line to mingw-cfg.site: gl_cv_func_pthread_sigmask_macro=no If that doesn't help, please show the relevant parts of your config.log. Anything that matches "pthread". (On my box the problem doesn't happen because I don't have the pthread.h header polluting my system.)