From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions' Date: Sat, 06 Jul 2019 11:08:41 +0300 Message-ID: <8336jja8l2.fsf@gnu.org> References: <83h88tzbly.fsf@gnu.org> <835zp9z4oj.fsf@gnu.org> <83y325xnk0.fsf@gnu.org> <83k1doy5om.fsf@gnu.org> <83d0jgxt83.fsf@gnu.org> <83wohmvpng.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49251"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36190@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 06 10:09:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjfks-000CgV-AB for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jul 2019 10:09:10 +0200 Original-Received: from localhost ([::1]:58230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjfkr-0005C5-Af for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jul 2019 04:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37386) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjfkl-00059z-DK for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 04:09:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjfkk-0007zB-HT for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 04:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjfkk-0007z0-Dr for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 04:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjfkk-000348-8t for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 04:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2019 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36190 X-GNU-PR-Package: emacs Original-Received: via spool by 36190-submit@debbugs.gnu.org id=B36190.156240053511771 (code B ref 36190); Sat, 06 Jul 2019 08:09:02 +0000 Original-Received: (at 36190) by debbugs.gnu.org; 6 Jul 2019 08:08:55 +0000 Original-Received: from localhost ([127.0.0.1]:54162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjfkd-00033n-Aq for submit@debbugs.gnu.org; Sat, 06 Jul 2019 04:08:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjfkb-00033a-6H for 36190@debbugs.gnu.org; Sat, 06 Jul 2019 04:08:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjfkV-0007ld-8A; Sat, 06 Jul 2019 04:08:48 -0400 Original-Received: from [176.228.60.248] (port=1675 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjfkU-0007aq-KJ; Sat, 06 Jul 2019 04:08:47 -0400 In-reply-to: (message from Pip Cet on Sat, 15 Jun 2019 19:27:30 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162186 Archived-At: > From: Pip Cet > Date: Sat, 15 Jun 2019 19:27:30 +0000 > Cc: 36190@debbugs.gnu.org > > > Looks better to me, but I'd suggest a comment explaining why we do > > such an unusual thing. > > Sounds good to me. The attached patch contains the comments and a hint > in the documentation. (Maybe the comments should be a FIXME, because > there's really no need to switch buffers at all when there are no > applicable hooks?) I'm okay with adding such a FIXME. > Obviously, feel free to reword as you consider appropriate. LGTM, with a couple of minor comments below. Feel free to push after fixing those. > + /* Ensure we run the modification hooks for the right buffer, > + without switching buffers twice (bug 36190). */ ^^ Here and elsewhere please keep 2 spaces between the period and "*/" > + if (BUFFERP (object) && XBUFFER (object) != current_buffer) > + { > + ptrdiff_t count = SPECPDL_INDEX (); > + record_unwind_current_buffer (); > + set_buffer_internal (XBUFFER (object)); > + return unbind_to (count, Fremove_list_of_text_properties (start, end, > + list_of_properties, > + object)); > + } The indentation here is too deep; suggest reformatting, e.g., by inserting a newline before Fremove_list_of_text_properties, and then reindenting the rest.