From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 20150@debbugs.gnu.org
Subject: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED)
Date: Sat, 13 Jul 2019 16:24:56 +0300 [thread overview]
Message-ID: <8336ja12zb.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmnUUL+_N75H5n86J7_VJ3tPs+XXLT5tq5bGPHAbZzpH=A@mail.gmail.com> (message from Stefan Kangas on Sat, 13 Jul 2019 15:09:39 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Sat, 13 Jul 2019 15:09:39 +0200
> Cc: 20150@debbugs.gnu.org
>
> > Hmm... we declare a non-internal variable obsolete and replace it with
> > an internal variable? Why is that a good idea? Does the new variable
> > have to be internal?
>
> I thought about it a bit more, and I guess it doesn't have to be internal. I
> suggest that the new variable should be kept internal for now though.
You mean, it doesn't have to be obsolete?
> I also don't know why I named the new variable bookmark-annotation--name, so
> I've changed that to bookmark--annotation-name to better reflect current
> practices.
Hmm... I don't see bookmark--annotation-name in the patch. Did you
send the correct patch?
next prev parent reply other threads:[~2019-07-13 13:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 7:24 bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Boruch Baum
2015-03-20 14:28 ` Stefan Monnier
2015-03-20 16:22 ` Boruch Baum
2019-07-02 1:54 ` Stefan Kangas
2019-07-02 3:23 ` Stefan Kangas
2019-07-03 20:05 ` Stefan Kangas
2019-07-04 19:20 ` Stefan Kangas
2019-07-04 19:40 ` Stefan Kangas
2019-07-13 7:30 ` Eli Zaretskii
2019-07-13 13:09 ` Stefan Kangas
2019-07-13 13:24 ` Eli Zaretskii [this message]
2019-07-13 13:51 ` Stefan Kangas
2019-07-14 1:48 ` Glenn Morris
2019-07-14 6:04 ` Eli Zaretskii
2019-07-14 6:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336ja12zb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20150@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.