cl-extra.el : any support for bool-vector type?

cl-extra.el : any support for bool-vector type?

[Philippe Schnoebelen]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Was surprised to see that

    (cl-map 'vector #'not '(nil nil 2 3 nil 5 nil 7 nil nil nil 11))

is accepted by emacs while

    (cl-map 'bool-vector #'not '(nil nil 2 3 nil 5 nil 7 nil nil nil 11))

fails with (error "Unknown type bool-vector").

Turns out that cl-extra.el does not support bool-vectors. Is there any
reason for this? Not knowing of any, I've just added one line to
cl-coerce and now I can coerce to bool-vectors. See attachment. Let me
know if I'm being reckless ...  -phs


[-- Attachment #2: patch-against-commit-77ee23d1ed --]
[-- Type: text/plain, Size: 572 bytes --]

diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el
index ca33c56a95..117c991ffe 100644
--- a/lisp/emacs-lisp/cl-extra.el
+++ b/lisp/emacs-lisp/cl-extra.el
@@ -47,6 +47,7 @@ cl-coerce
 TYPE is a Common Lisp type specifier.
 \n(fn OBJECT TYPE)"
   (cond ((eq type 'list) (if (listp x) x (append x nil)))
+	((eq type 'bool-vector) (if (bool-vector-p x) x (apply #'bool-vector (cl-coerce x 'list))))
 	((eq type 'vector) (if (vectorp x) x (vconcat x)))
 	((eq type 'string) (if (stringp x) x (concat x)))
 	((eq type 'array) (if (arrayp x) x (vconcat x)))

Re: cl-extra.el : any support for bool-vector type?

[Zhu Zihao]

AFAIK, `cl` package is a simulation of Common Lisp, and ANSI CL didn't define
bool vector(but there was bit-vector).

If you want to add support for such data structure, why not do it in `seq.el`?

Re: cl-extra.el : any support for bool-vector type?

[Eli Zaretskii]

> From: Philippe Schnoebelen <schnoebelen.ph@gmail.com>
> Date: Sun, 28 Jul 2019 08:59:12 +0200
> 
> Was surprised to see that
> 
>     (cl-map 'vector #'not '(nil nil 2 3 nil 5 nil 7 nil nil nil 11))
> 
> is accepted by emacs while
> 
>     (cl-map 'bool-vector #'not '(nil nil 2 3 nil 5 nil 7 nil nil nil 11))
> 
> fails with (error "Unknown type bool-vector").
> 
> Turns out that cl-extra.el does not support bool-vectors. Is there any
> reason for this? Not knowing of any, I've just added one line to
> cl-coerce and now I can coerce to bool-vectors. See attachment. Let me
> know if I'm being reckless ...  -phs

Thanks, I pushed this to the master branch.