From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37185: 24.5.1: vc--add-line, vc--remove-regexp are sub-optimal Date: Mon, 26 Aug 2019 09:44:10 +0300 Message-ID: <8336hoh1dx.fsf@gnu.org> References: <8d3275a0-149c-6f6a-ff22-c6ef27395188@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="217804"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37185@debbugs.gnu.org To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 26 08:45:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i28l2-000uXx-Fc for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 08:45:40 +0200 Original-Received: from localhost ([::1]:50306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i28l0-0002un-Nx for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 02:45:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33877) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i28kS-0002u4-Qk for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 02:45:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i28kR-0002IC-1h for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 02:45:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i28kQ-0002GW-2k for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 02:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i28kP-0001Yu-Tg for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 02:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2019 06:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37185 X-GNU-PR-Package: emacs Original-Received: via spool by 37185-submit@debbugs.gnu.org id=B37185.15668018595924 (code B ref 37185); Mon, 26 Aug 2019 06:45:01 +0000 Original-Received: (at 37185) by debbugs.gnu.org; 26 Aug 2019 06:44:19 +0000 Original-Received: from localhost ([127.0.0.1]:45491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i28jj-0001XU-Ct for submit@debbugs.gnu.org; Mon, 26 Aug 2019 02:44:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i28jh-0001XI-8y for 37185@debbugs.gnu.org; Mon, 26 Aug 2019 02:44:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i28jb-0001bv-T7; Mon, 26 Aug 2019 02:44:11 -0400 Original-Received: from [176.228.60.248] (port=3943 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i28jb-00036R-9S; Mon, 26 Aug 2019 02:44:11 -0400 In-reply-to: <8d3275a0-149c-6f6a-ff22-c6ef27395188@gmx.de> (message from Wolfgang Scherer on Sun, 25 Aug 2019 22:32:35 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165882 Archived-At: > From: Wolfgang Scherer > Date: Sun, 25 Aug 2019 22:32:35 +0200 > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 4cac153..bd0b601 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -1449,20 +1449,21 @@ Argument BACKEND is the backend you are using." >  ;; Subroutine for `vc-git-ignore' and `vc-hg-ignore'. >  (defun vc--add-line (string file) >    "Add STRING as a line to FILE." > -  (with-temp-buffer > -    (insert-file-contents file) Thank you for your contributions. I expect them to be reviewed soon, but let me point out that the patches you are sending (in this and other bug reports) have 2 problems which will make their application harder than necessary: . the whitespace is converted to 0x00a0 NBSP characters, which do not exist in the original sources . the patches lack commit log messages, in the format described in the file CONTRIBUTE in the top-level directory of the Emacs sources It is best to generate your patches using "git format-patch" and then send them as an attachment, I think this will solve these problems, assuming that you commit locally with the appropriate log message as described in CONTRIBUTE. Thanks again for your interest in Emacs.