From: Eli Zaretskii <eliz@gnu.org>
To: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
Cc: 37185@debbugs.gnu.org
Subject: bug#37185: 24.5.1: vc--add-line, vc--remove-regexp are sub-optimal
Date: Mon, 26 Aug 2019 09:44:10 +0300 [thread overview]
Message-ID: <8336hoh1dx.fsf@gnu.org> (raw)
In-Reply-To: <8d3275a0-149c-6f6a-ff22-c6ef27395188@gmx.de> (message from Wolfgang Scherer on Sun, 25 Aug 2019 22:32:35 +0200)
> From: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
> Date: Sun, 25 Aug 2019 22:32:35 +0200
>
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 4cac153..bd0b601 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -1449,20 +1449,21 @@ Argument BACKEND is the backend you are using."
> ;; Subroutine for `vc-git-ignore' and `vc-hg-ignore'.
> (defun vc--add-line (string file)
> "Add STRING as a line to FILE."
> - (with-temp-buffer
> - (insert-file-contents file)
Thank you for your contributions. I expect them to be reviewed soon,
but let me point out that the patches you are sending (in this and
other bug reports) have 2 problems which will make their application
harder than necessary:
. the whitespace is converted to 0x00a0 NBSP characters, which do
not exist in the original sources
. the patches lack commit log messages, in the format described in
the file CONTRIBUTE in the top-level directory of the Emacs
sources
It is best to generate your patches using "git format-patch" and then
send them as an attachment, I think this will solve these problems,
assuming that you commit locally with the appropriate log message as
described in CONTRIBUTE.
Thanks again for your interest in Emacs.
next prev parent reply other threads:[~2019-08-26 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 20:32 bug#37185: 24.5.1: vc--add-line, vc--remove-regexp are sub-optimal Wolfgang Scherer
2019-08-26 6:44 ` Eli Zaretskii [this message]
2019-08-26 22:52 ` bug#37185: *** GMX Spamverdacht *** " Wolfgang Scherer
2019-08-27 7:37 ` Eli Zaretskii
2019-08-27 23:38 ` bug#37185: *** GMX Spamverdacht *** " Wolfgang Scherer
2019-09-14 0:45 ` bug#37185: " Dmitry Gutov
2019-09-16 17:14 ` Wolfgang Scherer
2019-09-16 17:15 ` Wolfgang Scherer
2019-12-24 22:39 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336hoh1dx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37185@debbugs.gnu.org \
--cc=Wolfgang.Scherer@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.