From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org
Subject: bug#37806: 27.0.50; Need to "extend" face-remap.el
Date: Sun, 20 Oct 2019 18:05:31 +0300 [thread overview]
Message-ID: <8336fn5uf8.fsf@gnu.org> (raw)
In-Reply-To: <20191020143930.ugxiakrap7yym6qw@Ergus> (message from Ergus on Sun, 20 Oct 2019 16:39:30 +0200)
> Date: Sun, 20 Oct 2019 16:39:30 +0200
> From: Ergus <spacibba@aol.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 37806@debbugs.gnu.org
>
> The proper fix must be to declare the vector in the C side using the
> real symbols like:
>
> Lisp_Object internal-lisp-face-attributes[LFACE_VECTOR_SIZE] = {
> Qnil QCfamily, QCfoundry, QCwidth QCheight,
> QCweight, QCslant, QCunderline, QCinverse_video,
> QCforeground, QCbackground, QCstipple, QCoverline,
> QCstrike_through, QCbox, QCfont, QCinherit, QCfontset,
> QCdistant_foreground, QCextend
> };
>
> But using makevector or a similar api from C.
Yes, and face-remap.el even says so.
You can "steal" the way this is done from coding.c, starting around
line 11635 (but there should be no need to staticpro a variable that
is visible from Lisp, unlike Vcoding_category_table).
Thanks.
next prev parent reply other threads:[~2019-10-20 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 9:14 bug#37806: 27.0.50; Need to "extend" face-remap.el Stephen Berman
2019-10-19 17:33 ` Eli Zaretskii
2019-10-20 12:21 ` Stephen Berman
2019-10-20 14:39 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-20 15:05 ` Eli Zaretskii [this message]
2019-10-21 7:20 ` Eli Zaretskii
2019-10-20 19:58 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-20 15:00 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-20 15:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336fn5uf8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37806@debbugs.gnu.org \
--cc=spacibba@aol.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.