From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 38966-done@debbugs.gnu.org
Subject: bug#38966: 27.0.60; Assertion failure in set_cursor_from_row
Date: Mon, 06 Jan 2020 21:50:51 +0200 [thread overview]
Message-ID: <8336cse544.fsf@gnu.org> (raw)
In-Reply-To: <12ea3c04-249a-96da-8c88-52dcb5ca8b66@gmx.at> (message from martin rudalics on Mon, 6 Jan 2020 20:06:21 +0100)
> Cc: 38966@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
> Date: Mon, 6 Jan 2020 20:06:21 +0100
>
> > I don't expect to have a window that has no lines showing text. I
> > believe we don't allow creation/resizing of windows to such a small
> > size? If that's not guaranteed, I'm okay with adding an assertion
> > somewhere, but that would be a separate problem: we never expected
> > such a calamity even before tab-lines were added.
>
> We did.
OK, let me rephrase: _I_ didn't, okay? IOW, the display code doesn't,
and AFAIR never did.
(For some reason I seem to make people angry today, and you seem to be
one of them. Apologies -- I don't know for what.)
> Try with emacs 26 loading my old test-popup-2.el (attached once
> more). Type C-x 2 and make the lower window as low as you can. Now
> hit F2. The lower window shows no text.
Why is such a window useful? I thought we had a minimum window height
beyond which we didn't allow to resize windows. Isn't that true
anymore?
> I plan a slight modification that would allow the minibuffer window to
> shrink to zero lines whenever it's not used. OTOH, zero size "normal"
> windows would allow to show the minibuffer window in a frame that can
> acommodate only one or two lines.
All I'm saying is that making the display code prepared to deal with
such windows might take more changes, and this would be a separate
issue, suitable for master, not for the release branch. OK?
> > If we don't call set_cursor_from_row, we will not have a cursor
> > displayed where it should be, which is a display bug in and of itself.
>
> Isn't that statement overly conservative? Sooner or later, Emacs will
> at least have to allow a mode where the region is not destroyed when a
> window is scrolled, allowing the cursor to disappear from the visible
> part of its buffer.
That's not the same situation. If point is not in the window, it's OK
not to display the cursor. But I'm talking about a situation where
point _is_ in the window.
> > Sorry, but that ship sailed a long time ago. You will have to make do
> > with the comments in dispextern.h, which document this weirdness.
>
> Which comment?
This one:
/* True means row is a mode or header/tab-line. */
bool_bf mode_line_p : 1;
> In either case, rest assured that ordinary people will
> have considerable troubles understanding code like the proposed
>
> if (row->tab_line_p)
> ++row;
> if (row->mode_line_p)
> ++row;
I added comments explaining what's going on.
> Notwithstanding my concerns, the patch fixes the bug here.
Thanks, pushed to the emacs-27 branch, and closing the bug.
next prev parent reply other threads:[~2020-01-06 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 9:19 bug#38966: 27.0.60; Assertion failure in set_cursor_from_row martin rudalics
2020-01-06 17:14 ` Eli Zaretskii
2020-01-06 19:06 ` martin rudalics
2020-01-06 19:50 ` Eli Zaretskii [this message]
2020-01-07 9:52 ` martin rudalics
2020-01-07 16:01 ` Eli Zaretskii
2020-01-07 17:38 ` martin rudalics
2020-01-07 17:48 ` Eli Zaretskii
2020-01-07 18:23 ` martin rudalics
2020-01-07 18:36 ` Eli Zaretskii
2020-01-07 18:58 ` martin rudalics
2020-01-07 19:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336cse544.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38966-done@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.