From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37527: [PATCH] Install C source code for for debugging help Date: Tue, 21 Jan 2020 19:02:56 +0200 Message-ID: <8336c8wxmn.fsf@gnu.org> References: <20190926200752.12563-1-eggert@cs.ucla.edu> <831rw2l3zu.fsf@gnu.org> <89682bf5-de07-b114-90d1-cff9e4d62e5f@cs.ucla.edu> <83tv8yjjaz.fsf@gnu.org> <877e5uglp8.fsf@gmx.de> <83lfuaj7ix.fsf@gnu.org> <878sq9a4tm.fsf@gmx.de> <83lfu9hscn.fsf@gnu.org> <87y2y8944m.fsf@gmx.de> <837e5siwmz.fsf@gnu.org> <87pnje6jaf.fsf@gmx.de> <87imp46f5n.fsf@gmx.de> <3c936479-9341-caf1-2d08-7c236a660061@cs.ucla.edu> <87lftwbn4t.fsf@gmx.de> <733562c8-8676-4c73-34ff-a3f6659e5b70@cs.ucla.edu> <838spvznjz.fsf@gnu.org> <875zkzpnpf.fsf@gmx.de> <83ftk3xxd2.fsf@gnu.org> <87lfq2rlh0.fsf@marxist.se> <89b5298c-bc22-06ae-635a-0bf6b9dccb56@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="45534"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, michael.albinus@gmx.de, 37527@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 21 18:05:55 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itwyP-000Bcq-DE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 18:05:53 +0100 Original-Received: from localhost ([::1]:58612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwyO-0006v6-8V for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 12:05:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42708) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwvf-0003iY-I6 for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 12:03:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itwve-0007rH-90 for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 12:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42387) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itwve-0007r6-5q for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 12:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itwvd-00071o-UQ for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 12:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37527 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37527-submit@debbugs.gnu.org id=B37527.157962617827007 (code B ref 37527); Tue, 21 Jan 2020 17:03:01 +0000 Original-Received: (at 37527) by debbugs.gnu.org; 21 Jan 2020 17:02:58 +0000 Original-Received: from localhost ([127.0.0.1]:48360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwva-00071X-AJ for submit@debbugs.gnu.org; Tue, 21 Jan 2020 12:02:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwvV-00071G-3A for 37527@debbugs.gnu.org; Tue, 21 Jan 2020 12:02:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1itwvP-0007n1-87; Tue, 21 Jan 2020 12:02:47 -0500 Original-Received: from [176.228.60.248] (port=3114 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1itwvO-0008Nw-0S; Tue, 21 Jan 2020 12:02:46 -0500 In-reply-to: <89b5298c-bc22-06ae-635a-0bf6b9dccb56@cs.ucla.edu> (message from Paul Eggert on Tue, 21 Jan 2020 01:13:53 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175011 Archived-At: > Cc: Michael Albinus , rgm@gnu.org, > 37527@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 21 Jan 2020 01:13:53 -0800 > > --- a/src/emacs.c > +++ b/src/emacs.c > @@ -522,6 +522,7 @@ init_cmdargs (int argc, char **argv, int skip_args, char const *original_pwd) > if (!NILP (etc_exists)) > { > Vinstallation_directory = Ffile_name_as_directory (dir); > + Vsource_directory = Vinstallation_directory; > break; > } > } > @@ -547,6 +548,7 @@ init_cmdargs (int argc, char **argv, int skip_args, char const *original_pwd) > { > tem = Fexpand_file_name (build_string (".."), dir); > Vinstallation_directory = Ffile_name_as_directory (tem); > + Vsource_directory = Vinstallation_directory; > break; > } Bother. Should we really step on source-directory like that? What if the original source tree still exists? Maybe it would be safer to introduce a new variable, say, install-source-directory?