From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 1e3b0f2: Improve doc strings of project.el Date: Fri, 10 Jul 2020 21:14:58 +0300 Message-ID: <83365zp78d.fsf@gnu.org> References: <87bllfqj82.fsf@warpmail.net> <83imfnxgt3.fsf@gnu.org> <626efe11-0f9c-081b-11dd-0d61cee8168d@yandex.ru> <83h7v7xf7w.fsf@gnu.org> <831rmayj55.fsf@gnu.org> <6dc2c2ac-8e17-f044-dc78-8c109f936ad2@yandex.ru> <83wo42w83e.fsf@gnu.org> <6762abf5-71c1-aa54-1bac-d4c90c20870b@yandex.ru> <831rmavsuq.fsf@gnu.org> <83a70wv4mj.fsf@gnu.org> <5542db0c-cc0d-2743-87ae-7728a0cc94bb@yandex.ru> <83ftaf2rj2.fsf@gnu.org> <43a8f8d4-83fb-f012-8e1d-c1a618b0ef59@yandex.ru> <83mu4m0vub.fsf@gnu.org> <44f2f1f4-ae34-f0bf-b153-f33b8ee6069f@yandex.ru> <83mu4fvjh3.fsf@gnu.org> <7c2e93d4-8d86-bbbb-77a0-bf5d73051907@yandex.ru> <83imf2t4w4.fsf@gnu.org> <95fd893e-0da5-4cdc-a3e8-3c22af750aae@yandex.ru> <837dvfs6wg.fsf@gnu.org> <8bc1f381-248f-5cee-c3c6-a29d411a2f74@yandex.ru> <837dvbphs0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16007"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philip@warpmail.net, theo@thornhill.no, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 10 20:16:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtxZ4-000460-HZ for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 20:16:02 +0200 Original-Received: from localhost ([::1]:50574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtxZ3-0000WD-IN for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 14:16:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtxYF-0008Hg-D9 for emacs-devel@gnu.org; Fri, 10 Jul 2020 14:15:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39867) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtxYE-000439-C4; Fri, 10 Jul 2020 14:15:10 -0400 Original-Received: from [176.228.60.248] (port=2184 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jtxYD-00086R-Dt; Fri, 10 Jul 2020 14:15:10 -0400 In-Reply-To: (message from Dmitry Gutov on Fri, 10 Jul 2020 17:57:12 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252831 Archived-At: > Cc: theo@thornhill.no, philip@warpmail.net, emacs-devel@gnu.org > From: Dmitry Gutov > Date: Fri, 10 Jul 2020 17:57:12 +0300 > > On 10.07.2020 17:27, Eli Zaretskii wrote: > > >> In the same fashion that the author of bug#41029 arrived at the number > >> of ~6000 buffers (we could ask). > > > > Please do ask, because I don't see how could hundreds of buffers > > belong to a project without being created by commands that know about > > the project. > > They can open a bunch of files that reside in a project's directory > (roughly speaking; if the project backend is directory-based). You don't > need a command named project-* to do that. We could add something to find-file, like we do for VC-related files. > >> I also worry about Tramp buffers, where both process invocations and > >> traversals up the directory tree are unavoidably slower. > > > > Once again, as long as a buffer's project is determined when the > > buffer is created > > I have already explained that we don't do that. project is not a minor > mode, and we don't waste CPU cycles determining each buffer's project > eagerly. Maybe we should waste those CPU cycles, so that they don't add up. > Which is most likely a plus for Tramp, we don't need to make buffer > opening even slower there. We could have a defcustom to disable that for those who will seldom if ever use project.el. And again, we do that for VC. > >> * file or directory -> project > >> * project -> list of files > > > > These should be updated when the file is added to a project or removed > > from it. Or maybe I don't see the difficulties you have in mind. > > File can be added to a project in a multitude of different ways. By > using Vim in a terminal, for instance. Or the 'touch' command. > > Removal also happens through different venues (removal in Dired, on 'rm' > in the terminal, or changing the project configuration to ignore the > said file). Why should we care about adding or removing a file that are not visited in Emacs? > > . it makes the doc string of project-switch-to-buffer intentionally > > obfuscated by "explaining" stuff in terms of the implementation, > > which makes it not very useful (as I already tried to explain in > > the past) > > What are you suggesting? Explain what project-current does, most probably, right in that doc string. > > . the new doc string is confusing: "if 'project-current' returns the > > same (equal) value" is incomplete, because it doesn't say the same > > as what > > Same as the current project value, if any (otherwise, same as the value > returned by the project selection prompt). Please fix the sentence, then. > > So that commit looks like a step backwards to me. > > Just because you don't like the new docstring? > > That's harsh. I didn't see any other significant changes, sorry.