From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: master 9d0385d: Fix problem with 8bit content-transfer-encoding in
 nndoc mbox files
Date: Fri, 21 Aug 2020 22:47:14 +0300
Message-ID: <83364fbx31.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="3356"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: larsi@gnus.org (Lars Ingebrigtsen)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 21 21:47:59 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1k9D13-0000k5-S2
	for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Aug 2020 21:47:57 +0200
Original-Received: from localhost ([::1]:56474 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1k9D12-0004Fp-V0
	for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Aug 2020 15:47:56 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34468)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1k9D0Q-0003RU-Tu
 for emacs-devel@gnu.org; Fri, 21 Aug 2020 15:47:18 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50282)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1k9D0Q-0001kp-IB; Fri, 21 Aug 2020 15:47:18 -0400
Original-Received: from [176.228.60.248] (port=2439 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1k9D0P-0000BX-BQ; Fri, 21 Aug 2020 15:47:17 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:254086
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/254086>

> --- a/lisp/gnus/nndoc.el
> +++ b/lisp/gnus/nndoc.el
> @@ -352,6 +352,7 @@ from the document.")
>  	    nndoc-group-alist)
>        (setq nndoc-dissection-alist nil)
>        (with-current-buffer nndoc-current-buffer
> +	(set-buffer-multibyte nil)
>  	(erase-buffer)
>  	(condition-case error
>  	    (if (and (stringp nndoc-address)
> 

I think you want to swap the order: first erase-buffer, and then
set-buffer-multibyte.  That's because the latter in a non-empty buffer
can be expensive, and tis actually waste of cycles if you are going to
erase the buffer.