From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master e5392d3: Make easymenu downcase the menu symbol for greater backwards compat Date: Tue, 02 Mar 2021 15:56:45 +0200 Message-ID: <8335xd7j6q.fsf@gnu.org> References: <20210301212446.5364.12431@vcs0.savannah.gnu.org> <20210301212448.4653D20E1B@vcs0.savannah.gnu.org> <87sg5eyrof.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9433"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rgm@gnu.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 02 14:58:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lH5Xg-0002Hz-9H for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Mar 2021 14:58:28 +0100 Original-Received: from localhost ([::1]:47956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH5Xf-0006C8-B2 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Mar 2021 08:58:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH5W6-0005QE-0b for emacs-devel@gnu.org; Tue, 02 Mar 2021 08:56:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40596) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH5W5-0005cO-LW; Tue, 02 Mar 2021 08:56:49 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3703 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lH5W3-0007zP-N0; Tue, 02 Mar 2021 08:56:48 -0500 In-Reply-To: <87sg5eyrof.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 02 Mar 2021 07:51:12 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265827 Archived-At: > From: Lars Ingebrigtsen > Date: Tue, 02 Mar 2021 07:51:12 +0100 > Cc: emacs-devel@gnu.org > > Changing `lookup-key' to accept both forms (like Eli) suggests in a > followup would be better, of course, if it can be done efficiently. It should be as efficient as before for the case of a literal match; it will be less efficient for a non-literal match or a mismatch. > easymenu should also be extended with a form to allow explicitly > specifying the symbol to use: For instance, if you change the name of > the menu now, the symbol will also change. So for backwards > compatibility, symbols should be specified when changing the name in > easymenu calls. That'd be fine with me, but then (a) we should make sure the symbols are in fact specified in all the uses of easymenu that replace existing menus; and (b) would that still leave easymenu so much more convenient to justify the switch?