From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Proposal: ls-lisp.el handle --group-directories-first flag Date: Fri, 16 Jul 2021 14:57:51 +0300 Message-ID: <8335se5v40.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23387"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 16 13:58:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4MUa-0005qK-Fe for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Jul 2021 13:58:56 +0200 Original-Received: from localhost ([::1]:54228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4MUZ-00030M-H8 for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Jul 2021 07:58:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4MTn-00014H-BQ for emacs-devel@gnu.org; Fri, 16 Jul 2021 07:58:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49102) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4MTm-00048v-IM; Fri, 16 Jul 2021 07:58:06 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4MTl-00034Z-V0; Fri, 16 Jul 2021 07:58:06 -0400 In-Reply-To: (message from Arthur Miller on Thu, 15 Jul 2021 11:19:52 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271298 Archived-At: > From: Arthur Miller > Date: Thu, 15 Jul 2021 11:19:52 +0200 > > Just a minor 'out-of-the-box' quality of life improvement mostly for > MS Windows users. ls-lisp.el is default on MS Windows, and some users > might share their init configuration between their Gnu/Linux and MS > Windows systems, it might be nice to have ls-lisp.el recognize > `--group-directories-first' flag of Gnu ls program. > > I have just piggy-back on existing code here; I am not sure if I can > actually set `ls-lisp-dirs-firs' var to `t' when > `--group-directories-first' is found, so I am just converting this flag > to `y' so we can per-use existing machinery. But I would happily skip > `y' if it is acceptable to change users choice for `ls-lisp-dirs-first' > variable when `--group-directories-first' is present. This is not future-proof: what if 'ls' in some future release will have the -y option, and we'd want to support that in ls-lisp.el? Doesn't it work to let-bind ls-lisp-dirs-first? Thanks.