From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: larsi@gnus.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: emacs.pdmp not always rebuilt
Date: Mon, 04 Oct 2021 16:30:46 +0300 [thread overview]
Message-ID: <8335pg7w8p.fsf@gnu.org> (raw)
In-Reply-To: <6c697805381c56ec6eda@heytings.org> (message from Gregory Heytings on Mon, 04 Oct 2021 13:05:11 +0000)
> Date: Mon, 04 Oct 2021 13:05:11 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: larsi@gnus.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org
>
> > or simply test if substitute-command-keys is fboundp, and avoid using it
> > if not.
>
> That would be another option, yes. I don't think it's much better though,
> as Stefan K said a few hours ago the potential effect on
> substitute-command-keys on error messages during the build is minor.
I don't think that's what Stefan meant to convey, but if he did, I
disagree. I think avoiding the call if the function is not available
is the cleanest solution, one that we use elsewhere in Emacs in
similar cases. "Punishing" the entire loadup process because of a
small window where the function is not yet known is sub-optimal, IMO.
next prev parent reply other threads:[~2021-10-04 13:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 12:41 emacs.pdmp not always rebuilt Lars Ingebrigtsen
2021-10-03 12:53 ` Eli Zaretskii
2021-10-03 13:10 ` Lars Ingebrigtsen
2021-10-03 14:35 ` Stefan Monnier
2021-10-03 14:38 ` Lars Ingebrigtsen
2021-10-03 23:27 ` Gregory Heytings
2021-10-04 0:45 ` Stefan Kangas
2021-10-04 2:28 ` Eli Zaretskii
2021-10-04 8:57 ` Gregory Heytings
2021-10-04 9:19 ` Lars Ingebrigtsen
2021-10-04 11:14 ` Stefan Kangas
2021-10-04 12:53 ` Eli Zaretskii
2021-10-04 12:50 ` Eli Zaretskii
2021-10-04 13:05 ` Gregory Heytings
2021-10-04 13:25 ` Gregory Heytings
2021-10-04 13:37 ` Eli Zaretskii
2021-10-04 14:18 ` Gregory Heytings
2021-10-04 14:34 ` Eli Zaretskii
2021-10-04 16:02 ` Gregory Heytings
2021-10-04 16:56 ` Eli Zaretskii
2021-10-04 13:30 ` Eli Zaretskii [this message]
2021-10-04 14:03 ` Stefan Kangas
2021-10-04 14:19 ` Gregory Heytings
2021-10-04 15:10 ` Eli Zaretskii
2021-10-03 14:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335pg7w8p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.