From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Date: Sat, 15 Oct 2022 16:25:23 +0300 Message-ID: <8335bp6wxo.fsf@gnu.org> References: <878rlhtfew.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28468"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58547@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 15 15:30:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojhFG-0007DS-Lf for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 15:30:30 +0200 Original-Received: from localhost ([::1]:33560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojhFF-0007X9-6l for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 09:30:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhAw-0002rt-T6 for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojhAw-0003rq-KU for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojhAw-0006dW-7N for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58547-submit@debbugs.gnu.org id=B58547.166584035525495 (code B ref 58547); Sat, 15 Oct 2022 13:26:02 +0000 Original-Received: (at 58547) by debbugs.gnu.org; 15 Oct 2022 13:25:55 +0000 Original-Received: from localhost ([127.0.0.1]:39787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhAp-0006d9-An for submit@debbugs.gnu.org; Sat, 15 Oct 2022 09:25:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhAl-0006cs-Bk for 58547@debbugs.gnu.org; Sat, 15 Oct 2022 09:25:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhAf-0003li-5d; Sat, 15 Oct 2022 09:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hvl8HD35hR/QIep1TT7oV+39fGh2I6cXL4BrbNlptMI=; b=OgDcfUC+1alf 0W8zYYWfJJ8byNzjcZSpsMvFLm6HoUXlAvq/w8qnk8QJL3oxXecKadcgiorIBzUF+pQ/V8ehiCAdn k0h/C0VqIVfnP5v2yVnEj0uH/D2XY6OfZ8XCZWLLgGaHs3rp+FmEmVkwlGNSzFcinUvbyrpHvkz87 W6Amr/xdSdI3V5qESG9znheIWa5Xnkntkmoy5LJI7W/DtfK1pdrvZ4kYkiMagyysdBnLh4wqDs939 m0W6jtmlV3ScAvN3s9YxPtAu2mrPt4MoyV5s0CusSKTsSaXKiuYGHW7c4unJYWlVTcaigKxafj/ds 09SBSwPtQUvbBXllLO9O0w==; Original-Received: from [87.69.77.57] (port=3408 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhAM-0004MR-Oh; Sat, 15 Oct 2022 09:25:44 -0400 In-Reply-To: <878rlhtfew.fsf@elite.giraud> (message from Manuel Giraud on Sat, 15 Oct 2022 14:55:19 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245550 Archived-At: > From: Manuel Giraud > Date: Sat, 15 Oct 2022 14:55:19 +0200 > > I don't know if those kind of bikesheeding patch are accepted but I > think that "estimate_mode_line_height" is not a good name since it can > be (and is!) called with others face id. These lines are all considered "mode lines" in the display code, and have the mode_line_p flag set. So "mode line" is used here in a slightly different sense than it might seem at first glance. That said, I would not object to renaming this function, but only if the new name makes more sense. "Line with face" is too general to make sense, because basically every line on a typical Emacs display has some face. Also, if we are inventing a new collective name to these 3 display lines, we need to rename the mode_line_p flag to have the same name. Thanks.