From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list Date: Sat, 29 Oct 2022 08:56:04 +0300 Message-ID: <8335b7jhqj.fsf@gnu.org> References: <166668943749.31970.9379739764487638921@vcs2.savannah.gnu.org> <20221025091717.DD9A3C0E4BF@vcs2.savannah.gnu.org> <834jvold15.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28599"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rms@gnu.org, joaotavora@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 07:57:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooeq3-0007Ig-Pz for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 07:56:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooepl-0002N1-Cu; Sat, 29 Oct 2022 01:56:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooepJ-0001X3-Is for emacs-devel@gnu.org; Sat, 29 Oct 2022 01:56:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooepH-0003lm-VH; Sat, 29 Oct 2022 01:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=sacISHOObXVvU7uB88mhGV4O2Pjm6y1LNF50IcFI1fM=; b=m+W2a9KQyPygBUnxaa3z y0XU9l1HJo4Hrz7Ys1o3491tmX/Fx6hBuQ9G1CJw1ck2w1dF0gwbnpsLm/gnS6PWCnAMmJlu+6/dU F2tndo8QGF3XgNfOkzTLw8NSsGGrn7ewT59vYOamtaMdKzTCsP+DaW22w0m/TugfSx8Imt3rOkCU5 u61R2jqkY0VeaVOpBH+H+en9UHvqf/2j7z/emajoQPzuHjLc++UXdtw4cEql5gob/mzCcV5dKA37n 08i2BDa0csBV2h8PJumIdYKKZKbWdPPwgi4UDl/aE2AEuZcNyURVDDoP2mDoCmV2mIT4SHkbP4rvr wCf6oyw9qyS8ug==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooepD-0007G1-Ge; Sat, 29 Oct 2022 01:56:08 -0400 In-Reply-To: (message from Stefan Kangas on Fri, 28 Oct 2022 12:45:58 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298721 Archived-At: > From: Stefan Kangas > Date: Fri, 28 Oct 2022 12:45:58 -0700 > Cc: joaotavora@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org > > Eli Zaretskii writes: > > > Our project-wide preference is the other way around: we ask > > contributors not to make any whitespace changes except where they > > actually change code, or nearby. > > AFAIK, the reasons not to do cosmetic whitespace changes is that they > make history harder to read, and merging harder. They also make patches harder to review, sometimes much harder. > However, any reasonably modern VCS will have an option to ignore > whitespace changes (Git does). And a lot of code in Emacs change very > infrequently. At the same time, whitespace changes can in some cases > make the structure of code clearer, and thereby easier to understand. > > I therefore think we could relax our project-wide policy along the lines > of what Richard and João suggest. Not as long as the "diff" operation of the VCS treats whitespace as significant by default. Presumably, they do this for a reason, and therefore patches we get to review do not ignore whitespace.