From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines Date: Mon, 05 Dec 2022 14:39:06 +0200 Message-ID: <83359u9g9h.fsf@gnu.org> References: <90faf628-390d-1094-2fcb-e6a23ac46da8@gmail.com> <83v8mrbpf7.fsf@gnu.org> <3d78b158-5fde-d4c0-0e9a-cb05e09bed6e@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27914"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59622@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 13:40:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2Alm-00072j-F2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 13:40:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2AlZ-0001bx-NW; Mon, 05 Dec 2022 07:40:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2AlO-0001bg-JF for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 07:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2AlO-0004OJ-2o for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 07:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2AlN-0000Nv-JS for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 07:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59622-submit@debbugs.gnu.org id=B59622.16702439701466 (code B ref 59622); Mon, 05 Dec 2022 12:40:01 +0000 Original-Received: (at 59622) by debbugs.gnu.org; 5 Dec 2022 12:39:30 +0000 Original-Received: from localhost ([127.0.0.1]:35775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Aks-0000Na-94 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 07:39:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Akq-0000NU-Jl for 59622@debbugs.gnu.org; Mon, 05 Dec 2022 07:39:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Akk-00043p-KV; Mon, 05 Dec 2022 07:39:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OkY5WTvdVA7ral0xfpuZWKyJ7G1UwKRWLEsQt1pnqNk=; b=FAhagGf2Z72v 2celVHOA6/VYrwgePxxMiCbfE9Zqg0HIf7RhaIVjSovU5q0BL1g0/NDHkPvreY3mL/wM1ZhGPFzEo 1pWftAzuKUH7wKLRO6iMb2UNqQeDY1WN+2zwpwaA/uCwi5iqOkHnH+JiiH7ylyGIzdTW2HEy8p4iz s8KJOxQQuya17KRk9xIh3tz5t+v4XtHdJewfr1Z3yBiEu314oCefEUZT2PWaPPL5RJmtDR3yFQgUm fTGPPbN2Ikw/qUvBQdwdeCxtOxPvSHBfSv/q+suehbbqRM8KgKOnKAkz19DAnHaZRotGUV/i99mew 4uJpnfqyOURDKGi6PJ/pDg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Akk-0003M6-0Y; Mon, 05 Dec 2022 07:39:22 -0500 In-Reply-To: <3d78b158-5fde-d4c0-0e9a-cb05e09bed6e@gmail.com> (message from Jim Porter on Sun, 4 Dec 2022 17:35:30 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250014 Archived-At: > Date: Sun, 4 Dec 2022 17:35:30 -0800 > Cc: 59622@debbugs.gnu.org > From: Jim Porter > > On 12/3/2022 11:26 PM, Eli Zaretskii wrote: > >> Date: Sat, 3 Dec 2022 17:41:50 -0800 > >> From: Jim Porter > >> > >> Eli, since this is a regression from Emacs 28 (likely fallout from one > >> of my changes to fix some longstanding bugs with quotes in Eshell), > >> would my current patch be ok on the release branch? > > > > Yes, but please do try to make it as safe as is feasible. > > Thanks. How does this look? I just simplified the change in > 'eshell-parse-backslash' so that the only difference is an extra > conditional (plus whitespace changes). Looks good, thanks. One comment: > +When you escape a character with @code{\} outside of quotes, the > +result is the literal character immediately following it, so > +@samp{\$10} means the literal string @code{$10}. Inside of > +double quotes, the result is the literal character following it if > +that character is special, or the full @code{\@var{c}} sequence > +otherwise; inside double-quotes, @code{\}, @code{"}, and @code{$} are > +considered special. The last sentence is very unclear, please try saying what you need in a clearer way, and/or maybe add a couple of examples.