From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sun, 11 Dec 2022 21:00:25 +0200 Message-ID: <83359lu5o6.fsf@gnu.org> References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5728"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59935@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 20:01:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4RZp-0001L1-Tm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 20:01:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4RZR-0000z1-4j; Sun, 11 Dec 2022 14:01:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4RZO-0000yp-W0 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 14:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4RZO-0004MZ-Mv for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 14:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4RZO-0001v8-1l for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 14:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 19:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707852347366 (code B ref 59935); Sun, 11 Dec 2022 19:01:02 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 19:00:34 +0000 Original-Received: from localhost ([127.0.0.1]:47696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RYw-0001uk-6H for submit@debbugs.gnu.org; Sun, 11 Dec 2022 14:00:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RYt-0001ue-Ms for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 14:00:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4RYn-00049o-Gc; Sun, 11 Dec 2022 14:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+IBpaWpNfKDDO9S/fRWW5XhrEa3KqKnM6rsBBvwC1ls=; b=qHxrlg61r+z2 E4hBiHWCsa3RqP8mem7yMPvH/2avFKahCXUvCNBNSZ4O1S1nZWJKiXg82BYpP7JSGow7iHpKfS/Q1 Zf7AawFy+woAZXZep4d3dEvkygEvXdXjDje6iSWojm7JOrFgOGWvbpq2dgbycl+AbCCadd5+T25FT 5DKTS9rqshsCs/LNkr5+L8QG4mbX1J58bqJcu3U8Yk0Nlqz8n2l+jjJaGrdc8W9uXxM6bhbVXrXKm NQFndWK4yh5Hj2B5pWOjhakPvTyZg1WL/pTyU+jJlY6RjSwjrjbBg/yMujYlNw20M5GG8AGDoVY/b Sdf8rAoKj77W+oog8/Gg9g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4RYn-0003gw-1S; Sun, 11 Dec 2022 14:00:25 -0500 In-Reply-To: <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> (message from Dmitry Gutov on Sun, 11 Dec 2022 20:35:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250649 Archived-At: > Date: Sun, 11 Dec 2022 20:35:24 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 11/12/2022 20:17, Eli Zaretskii wrote: > > Why not leave alone that additional PREDICATE > > argument of list-buffers-noselect, and add a feature where the > > BUFFER-LIST argument could be a function? That's be a compatible > > change. Just keep the PREDICATE argument and the code which supports > > it, and document that if PREDICATE is a function, BUFFER-LIST cannot > > be a function. > > While that should work, that change would *also* change the signature. > Though in a safer way, yes. Indeed. > Are you worried about some out-of-tree clients that started using the > new feature in the meantime? Yes. In particular, we never change signatures after the branch point of a release branch -- the branch point is a de-facto code-freeze point for the release branch. > Otherwise, this change could be split into two steps: > > - Rollback that signature to pre-commit 125b5684c (i.e. revert its part > in buff-menu.el). This is something we usually considered to be safe. > > - Add new change that allows BUFFER-LIST to be a function. We can do it safer, so I'd prefer that.