From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60001: [PATCH] Improve completion of treesit-check-indent command Date: Sun, 08 Jan 2023 13:53:33 +0200 Message-ID: <83358lqm2q.fsf@gnu.org> References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60001@debbugs.gnu.org, mardani29@yahoo.es To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 12:54:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEUFp-0007Q8-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 12:54:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEUFb-0007wH-SH; Sun, 08 Jan 2023 06:54:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEUFY-0007vm-Nh for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 06:54:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEUFW-0003Z1-Jc for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 06:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEUFW-0005zb-FG for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 06:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60001 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60001-submit@debbugs.gnu.org id=B60001.167317879822969 (code B ref 60001); Sun, 08 Jan 2023 11:54:02 +0000 Original-Received: (at 60001) by debbugs.gnu.org; 8 Jan 2023 11:53:18 +0000 Original-Received: from localhost ([127.0.0.1]:60088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEUEn-0005yP-Sr for submit@debbugs.gnu.org; Sun, 08 Jan 2023 06:53:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEUEm-0005y9-9N for 60001@debbugs.gnu.org; Sun, 08 Jan 2023 06:53:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEUEf-0003PL-UP; Sun, 08 Jan 2023 06:53:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+eMwyE1thTS75mMpx1fcepwdc4yY6kVfMmF2Y2m4sSc=; b=XEo2HajQVDMjiUfgERW0 G4nu8pdxWuX/vA2T7T1TEsQklDTQtL4WVhAAT2SWLWf5EDGjDO/v73GlQ7C+ne5pec55BRdhQU4OZ pxF57XnBzZHI+8lZ6tddfzZs6U7SUAkTLSNIGJasvXMsBNVghh4NE1krD+lL5UKy/AZB0HWnKeVDZ T2erQaIz8Vfnh2HgZjhoUBFxptIhH/BZ6gJ4WDx/Nv0RWzK164pbGb3Pa9QkI7rbxteFCnegP7WeN 605Av6PJ9HEf9pspe7Wr3aGJyq15jKP8n5U6WuDht0DD94qgngIBY7HcqV8IdosSL/0LANwU8vbo0 gsTHrWCx9F6A/A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEUEf-0005Sd-Fw; Sun, 08 Jan 2023 06:53:09 -0500 In-Reply-To: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> (message from Yuan Fu on Sat, 7 Jan 2023 15:13:54 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252914 Archived-At: > From: Yuan Fu > Date: Sat, 7 Jan 2023 15:13:54 -0800 > Cc: Daniel Martín , > 60001@debbugs.gnu.org > > > Eli Zaretskii writes: > > >> Date: Mon, 12 Dec 2022 11:53:00 +0100 > >> From: Daniel Martín via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> The treesit-check-indent command is not really related to Tree-sitter > >> and could be in a more general place than treesit.el. WDYT? > > > > I agree, but then we'd need a definition for it that doesn't need > > tree-sitter support. Is that easy to provide? > > > >> In any case, I have a patch to improve this command a bit by offering > >> more accurate completion for major modes, not Emacs commands. I have > >> also tried to improve its documentation a bit. > > > > How about a read-major-mode function in subr.el? > > > > But I think all these generalizations and improvements should go to > > master. On the release branch, I'd prefer to leave > > treesit-check-indent alone. > > Has this patch been pushed to master? No, I don't think so. > Should I close this report? If you agree with the change, please install it.