From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61504: 29.0.60; executing byte-code from previous build causes SIGSEGV crash Date: Tue, 14 Feb 2023 15:29:50 +0200 Message-ID: <833578e5o1.fsf@gnu.org> References: <0f053182b047f142abcf@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14190"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mi-ebugs@kismala.com, 61504@debbugs.gnu.org To: Gregory Heytings , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 14 15:18:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRw8t-0003XS-BF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Feb 2023 15:18:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRvOk-0008UL-0m; Tue, 14 Feb 2023 08:31:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRvOh-0008RM-BQ for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 08:31:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRvOg-0003Tu-SF for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 08:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRvOg-0000nF-Ey for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 08:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2023 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61504 X-GNU-PR-Package: emacs Original-Received: via spool by 61504-submit@debbugs.gnu.org id=B61504.16763814423017 (code B ref 61504); Tue, 14 Feb 2023 13:31:02 +0000 Original-Received: (at 61504) by debbugs.gnu.org; 14 Feb 2023 13:30:42 +0000 Original-Received: from localhost ([127.0.0.1]:52895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRvOL-0000mb-OT for submit@debbugs.gnu.org; Tue, 14 Feb 2023 08:30:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRvO9-0000m9-FS for 61504@debbugs.gnu.org; Tue, 14 Feb 2023 08:30:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRvO2-000358-PM; Tue, 14 Feb 2023 08:30:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=RaFJsGMeH9voHGXBWUDvGLOrYxXWDAVATYryQI3BHIM=; b=d96t7q1K7riPlw/VEDBd UmBoEuUWHDW8tuJKs2rxl8tzB1TlQl1ioqWof06asJ2BqkiqVoB4ho7VH5BiilbQP1IV8GbWsGzkt +3+rkBDEPjIuWPAAwFETTpQYi0I4gfc5MOmrsmWWQDa0R2xX9HEw/c2XhDnUv1szFxsPFROMmMAlw attdY9qMSaQwoSAYoNP38FotFhdq5rGB2RWWpdpV1wyDrjHBy1G0lGtL09oflqSEx1zxm0w3X4ihk HvTXyIDRT6bPffzKPiyrU+lMy2xof1R/jXgLscKFP0xA/UTLRQbXIgvZi0nY+W5/OAZYMsSy2KbUv hbndwz/a3eYdzA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRvNt-0001bV-3T; Tue, 14 Feb 2023 08:30:22 -0500 In-Reply-To: <0f053182b047f142abcf@heytings.org> (message from Gregory Heytings on Tue, 14 Feb 2023 09:29:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255585 Archived-At: > Date: Tue, 14 Feb 2023 09:29:32 +0000 > From: Gregory Heytings > cc: Eli Zaretskii , 61504@debbugs.gnu.org > > > There seems to be a byte-code change between versions > > 0ec0a610ed226419269f519021cbe8fb2dde2ed5 (old) and > > a4aa32bdfff7aaf54efbacbb04b7f2b52fef92a7 (new) which causes the new > > version to crash with SIGSEGV when executing certain code from an .elc > > built using the old version. Recompiling the file with the new version > > causes the new .elc to work correctly. > > > > The bytecode did not change, but the byte codes generated by the > save-restriction form did change. > > Now that I think of it again, it is possible make that change while > preserving backward compatibility. > > Eli, what do you think of the attached patch? It restores the 'unbind 1' > at the end of save-restriction, and puts the two data elements into a cons > instead of pushing them separately. (Of course this passes make and make > check, with and without native compilation.) I guess we have no choice. Mattias, Stefan: any better alternatives, or comments/objections?