all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: 61613@debbugs.gnu.org
Subject: bug#61613: 30.0.50; ffap-other-window ignores ffap-require-prefix
Date: Mon, 20 Feb 2023 19:01:20 +0200	[thread overview]
Message-ID: <833570uv8f.fsf@gnu.org> (raw)
In-Reply-To: <20230220154915.qm4smcoohaiyc52c@Ergus> (message from Ergus on Mon, 20 Feb 2023 16:49:15 +0100)

> Date: Mon, 20 Feb 2023 16:49:15 +0100
> From: Ergus <spacibba@aol.com>
> Cc: 61613@debbugs.gnu.org
> 
> >> So, what do you think? The fix may be to put the ffap-require-prefix
> >> condition in ffap-read-file-or-url directly or in ffap-prompter??
> >
> >I don't understand what you want to achieve by that, so please
> >elaborate.  ffap-file-finder's default value is a command that doesn't
> >display the file in another window, so how will ffap-require-prefix
> >help here?
> 
>  From the example above I expect that after:
> 
> (setq ffap-require-prefix t)
> C-x 4 f
> 
> You see ~/ instead of /somedir. Like when we do C-x C-f.

That's not what ffap-require-prefix does:

  (defcustom ffap-require-prefix nil
    "If set, reverses the prefix argument to `find-file-at-point'.
  This is nil so neophytes notice ffap.  Experts may prefer to disable
  ffap most of the time."

> As I said before, ffap-prompter is causing this because it is called
> before switching window.

So what we need is fix how the prompt is calculated, not what is the
meaning of the prefix arg.

> So ffap-file-finder is actually called at point before going to another
> window. And it does not have any ffap-require-prefix condition. My
> question is actually that.

Once again, calling ffap-file-finder in this case is WRONG!  We need a
function that visits the file in another window, and ffap-file-finder
doesn't.

IOW, you are talking about a very different change to
ffap-other-window.

> We need to put the ffap-require-prefix condition somewhere in
> ffap-read-file-or-url or ffap-prompter. Because this problem happens
> with the other-frame and other-tab variants as well.

I think we need to rewrite the interactive spec of those to do what
you want.  ffap-require-prefix is not related to this at all.





  reply	other threads:[~2023-02-20 17:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87pma6tlth.fsf.ref@aol.com>
2023-02-19  2:45 ` bug#61613: 30.0.50; ffap-other-window ignores ffap-require-prefix Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19  9:21   ` Eli Zaretskii
2023-02-19 10:09     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 10:15       ` Eli Zaretskii
2023-02-19 21:32         ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:50           ` Eli Zaretskii
2023-02-20 15:49             ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 17:01               ` Eli Zaretskii [this message]
2023-02-19 21:43         ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:51           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=833570uv8f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61613@debbugs.gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.