From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61962: 30.0.50; New trouble with symbols with positions Date: Tue, 07 Mar 2023 15:13:40 +0200 Message-ID: <83356g7lh7.fsf@gnu.org> References: <87o7p8v6ak.fsf@web.de> <83ilfga322.fsf@gnu.org> <877cvvqj5v.fsf@web.de> <877cvv0yv7.fsf@web.de> <87a60p4d5q.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, mattiase@acm.org, 61962@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 14:14:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZX8z-0005gt-5k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 14:14:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZX8o-00031S-2N; Tue, 07 Mar 2023 08:14:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZX8k-00031I-IC for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZX8k-0000LO-1h for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZX8j-00030p-Ou for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 13:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61962 X-GNU-PR-Package: emacs Original-Received: via spool by 61962-submit@debbugs.gnu.org id=B61962.167819483811563 (code B ref 61962); Tue, 07 Mar 2023 13:14:01 +0000 Original-Received: (at 61962) by debbugs.gnu.org; 7 Mar 2023 13:13:58 +0000 Original-Received: from localhost ([127.0.0.1]:44792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZX8f-00030R-P3 for submit@debbugs.gnu.org; Tue, 07 Mar 2023 08:13:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZX8d-00030D-Ap for 61962@debbugs.gnu.org; Tue, 07 Mar 2023 08:13:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZX8X-0000Jl-0P; Tue, 07 Mar 2023 08:13:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=6VqIcL9tiFR+sqbmVfVVy6/fRy6EZT5PIf064DtxC8I=; b=Ds1l8QT5y0uA4wmyONR7 tjBUUfIlafy0JW7OPgazHFdyFOguoLxkvYdPycjKVulP556JfQ8XtqRcfRP4pQ/2ZsbnIjkQ4D8hL ypnPamqhO109yaTx9Oz9WhBiJ46PhUGYwL+5CWBzBcUXa9cf2eUDMS/R/7s5Fn8hRiMu+iKImmx8u Mltmu3R+0z+mmYEwbMSApbu2kdPROXiGsYlh0ikMTqgFq3YCrRJnP6IZzQsvn8lQhUKxWOL22lGUb FHRywLBpqw7NMWeo6/fWFWRxXJ0SaDGO9M8xb66Ye5xZT9XZMpz2MZltq2I8nCx4T0evGkKSRHpVB IcKj9L4ZrkNoLA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZX8S-0003By-Kf; Tue, 07 Mar 2023 08:13:48 -0500 In-Reply-To: (message from Alan Mackenzie on Tue, 7 Mar 2023 10:24:41 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257447 Archived-At: > Date: Tue, 7 Mar 2023 10:24:41 +0000 > Cc: Mattias Engdegård , > Eli Zaretskii , 61962-done@debbugs.gnu.org > From: Alan Mackenzie > > I've now written safe-copy-tree, and committed it together with the fix > in bytecomp.el to master. Next time when you post a patch and ask for comments, please allow some time for responses, including to those who might be in different time zones or have less free time on their hands. 13 hours you waited is definitely not enough. Btw, what are these "NEW STOUGH" markers you added to bytecomp.el: +;;;; NEW STOUGH, 2023-03-05 + (byte-run-strip-symbol-positions +;;;; END OF NEW STOUGH (byte-compile-sexp (let ((form (read-positioning-symbols (current-buffer)))) (push form byte-compile-form-stack) (eval-sexp-add-defvars form - start-read-position)))) + start-read-position))) +;;;; NEW STOUGH, 2023-03-05 + ) +;;;; END OF NEW STOUGH + ) Also, how about adding some tests, to make sure we don't regress in this area in the future?