From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Date: Mon, 12 Jun 2023 19:40:24 +0300 Message-ID: <83352wy6pz.fsf@gnu.org> References: <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org> <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org> <87352w6fd8.fsf@gmx.de> <83edmgygew.fsf@gnu.org> <87sfawhj91.fsf@gmail.com> <83a5x4yci0.fsf@gnu.org> <87o7lkhdwz.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40794"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 12 18:41:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8kbS-000ATC-EQ for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jun 2023 18:41:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8kag-0002bS-Sz; Mon, 12 Jun 2023 12:40:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8kaf-0002bI-Ij for emacs-devel@gnu.org; Mon, 12 Jun 2023 12:40:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8kaf-0008Dg-0u; Mon, 12 Jun 2023 12:40:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XDzpJiLnxTwW3EJDoPawEsckMeRN6DsVXelUKnoURDs=; b=gI21wCj9V/Pw LKlJpVLos/O11rJRtRaaFf5VWcGkOtVixUhyPobG4ZgyemcVMJ3x64y/kt9Xteez56x0jZx1w5CZv U8d0ZHZM0+8PklvbN4TTPN1gotor8LTp5z+CWoUCa+vne2zSYLav5MO+4pZAh6sdOm2IyLM0NRjOu ugt1TRCWWg7sPmjG7d/5aDE/uhitlGnciHevPun9lsNixmgb7iZhIX4xqEuCw9gRt6mf1s9GK8OUf Z1TvAf6asLCYq44yDUs3u/K+i1278HLkV5f79dJGq+cOWIp5Wd4o6NNEVboI6TWSyvoXBgq7iecU5 m5N12lNhUq5+CJBKygZ6zw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8kaO-0002IO-TI; Mon, 12 Jun 2023 12:40:24 -0400 In-Reply-To: <87o7lkhdwz.fsf@gmail.com> (message from Robert Pluim on Mon, 12 Jun 2023 17:57:00 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306754 Archived-At: > From: Robert Pluim > Cc: michael.albinus@gmx.de, emacs-devel@gnu.org > Date: Mon, 12 Jun 2023 17:57:00 +0200 > > The minimal fix would be: > > diff --git a/lisp/window.el b/lisp/window.el > index 78b0787abdb..16f16a75418 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -8776,7 +8776,7 @@ display-comint-buffer-action > :group 'windows > :group 'comint) > > -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window > +(defcustom display-tex-shell-buffer-action '(display-buffer-in-previous-window) > "`display-buffer' action for displaying TeX shell buffers." > :type display-buffer--action-custom-type > :risky t Fine by me, please install. > Although if we went by analogy to `display-comint-buffer-action', it > would have to be this: > > diff --git a/lisp/window.el b/lisp/window.el > index 78b0787abdb..0213023e495 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -7575,6 +7575,13 @@ display-buffer--same-window-action > Specifies to call `display-buffer-same-window'.") > (put 'display-buffer--same-window-action 'risky-local-variable t) > > +(defvar display-buffer--in-previous-window-action > + '(display-buffer-in-previous-window > + (inhibit-same-window . t)) > + "A `display-buffer' action for displaying in the previous window. > +Specifies to call `display-buffer-in-previous-window'.") > +(put 'display-buffer--in-previous-window-action 'risky-local-variable t) > + > (defvar display-buffer--other-frame-action > '((display-buffer-reuse-window > display-buffer-pop-up-frame) > @@ -8776,7 +8783,7 @@ display-comint-buffer-action > :group 'windows > :group 'comint) > > -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window > +(defcustom display-tex-shell-buffer-action display-buffer--in-previous-window-action > "`display-buffer' action for displaying TeX shell buffers." > :type display-buffer--action-custom-type > :risky t Why do we need an extra variable here?