all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Spencer Baugh" <sbaugh@janestreet.com>,
	"João Távora" <joaotavora@gmail.com>
Cc: sbaugh@catern.com, 64428@debbugs.gnu.org
Subject: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode
Date: Thu, 06 Jul 2023 17:04:39 +0300	[thread overview]
Message-ID: <833521i1ag.fsf@gnu.org> (raw)
In-Reply-To: <iersfa1i3ie.fsf@janestreet.com> (message from Spencer Baugh on Thu, 06 Jul 2023 09:16:41 -0400)

> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: sbaugh@catern.com,  64428@debbugs.gnu.org
> Date: Thu, 06 Jul 2023 09:16:41 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> * lisp/progmodes/flymake.el:(flymake--mode-line-counter-scroll-prev,
> >> flymake--mode-line-counter-scroll-next,
> >> flymake--mode-line-counter-map): Add.
> >> (flymake--mode-line-counter): Use new keymap and include 'type as a
> >> property in the mode-line.
> >
> > Thanks.  Any reason you couldn't simply add more events to the
> > existing code?
> 
> Two reasons:
> 
> 1. I initially did that but it made the code uglier.  Also, this code is
> run every time the mode-line is updated, and adding more of that seems
> bad.
> 
> 2. This makes describe-key work better and makes it possible for users
> to configure the scroll direction or add more bindings for different
> things.

This means your changeset is actually two different loosely-related
changes.  The one that refactors the original code needs approval from
João (CC'ed).  Once João is happy with that refactoring, I'm okay with
adding the extra events to it.





  reply	other threads:[~2023-07-06 14:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 21:51 bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode sbaugh
2023-07-06  7:37 ` Eli Zaretskii
2023-07-06 13:16   ` Spencer Baugh
2023-07-06 14:04     ` Eli Zaretskii [this message]
2023-07-07 11:37       ` João Távora
2023-07-07 11:47         ` João Távora
2023-07-07 12:12           ` sbaugh
2023-07-13  5:56             ` Eli Zaretskii
2023-07-13  8:12               ` João Távora
2023-07-13 14:00                 ` Eli Zaretskii
2023-07-07 12:52         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=833521i1ag.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64428@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=sbaugh@catern.com \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.