From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Mon, 17 Jul 2023 14:54:06 +0300 Message-ID: <83351m92jl.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83bkgb8xo5.fsf@gnu.org> <87jzuz1uq5.fsf@localhost> <83a5vv8edp.fsf@gnu.org> <87ttu2zydc.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37341"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 13:54:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLMo1-0009V2-Lw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 13:54:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLMnj-0006DD-Sz; Mon, 17 Jul 2023 07:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLMni-00067S-Eu for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 07:54:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLMnh-0003wS-UP for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 07:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLMnh-00006k-KT for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 07:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 11:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.1689594833400 (code B ref 64596); Mon, 17 Jul 2023 11:54:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 17 Jul 2023 11:53:53 +0000 Original-Received: from localhost ([127.0.0.1]:49222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLMnY-00006N-DJ for submit@debbugs.gnu.org; Mon, 17 Jul 2023 07:53:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLMnT-000067-Dh for 64596@debbugs.gnu.org; Mon, 17 Jul 2023 07:53:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLMnN-0003rw-Rc; Mon, 17 Jul 2023 07:53:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+OBqOVDViVeEta57hFN8DMqOn52k76PwHUYCtuCD9nM=; b=Vcr1Ox+4baLP FsKSH1VH4sMuwjMSufqlpuNYZsBoRSqIyfRDUz2RWSdlZDOdVffbcVW8RJSx4WzhTzJMcB5lbt2LE h+tRX4m9/pf+m7uOwqMYRDSmJOwA+wXOunI75mb/BgTtuHRG+budwWVLqjx2E1+MIVcnaJxSfZhsr TPT6vjo8JYY5GwPNiCxlGqpXTtHJkVC7dzd76QbeH74xHcZM5zKtOPALH6TyGRuPmzS+qidiGWy2G KY/4qUdUVf8ezhlw66Ib+KwHg4R2w1K5HN3YuDq+r8pd+EFm9IX9wmaroAkT9RSvJ94Mk801sx91H 9+EvmrXiV91+fgEuzUanaQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLMnM-00050D-Ut; Mon, 17 Jul 2023 07:53:41 -0400 In-Reply-To: <87ttu2zydc.fsf@localhost> (message from Ihor Radchenko on Mon, 17 Jul 2023 09:22:07 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265382 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org > Date: Mon, 17 Jul 2023 09:22:07 +0000 > > Eli Zaretskii writes: > > >> > Actually, the must_be_updated_p flag is not for xdisp.c, i.e. not for > >> > redisplay_window and its subroutines. It is for update_window, which > >> > is the last, 3rd, stage of a redisplay cycle, most of the code of > >> > which is in dispnew.c... > >> > >> I have to say that these flag names are very disorienting. > >> I have first seen this flag while reading xdisp.c, and it was not obvious > >> at all what it does. > > > > Well, update_frame and update_window are the relevant functions in > > dispnew.c, so "must_be_updated_p" kind-of points to them. > > This does not help the confusion, unfortunately. > Or maybe the terms "redisplay" and "update" should be explained better > somewhere near the top of xdisp.c. They clearly have different meaning, > but not for untrained eye. "Update" is the general name of the 3rd step of "redisplay cycle". It takes its name from the function which enters this step: update_frame.