From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 66825@debbugs.gnu.org
Subject: bug#66825: last-coding-system-used in basic-save-buffer
Date: Sun, 29 Oct 2023 21:27:19 +0200 [thread overview]
Message-ID: <8334xtb560.fsf@gnu.org> (raw)
In-Reply-To: <86v8apv3m7.fsf_-_@mail.linkov.net> (message from Juri Linkov on Sun, 29 Oct 2023 20:40:32 +0200)
> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 29 Oct 2023 20:40:32 +0200
>
> Indeed, the problem is in basic-save-buffer on the following line:
>
> (setq buffer-file-coding-system last-coding-system-used)
>
> It's hard to guess why this code relies on the value that
> can be changed by other functions during saving the buffer.
Because this is the protocol: functions that determine the encoding of
buffer text dynamically set this variable, so it could later be used
to reflect the detection in buffer-file-coding-system.
> For example,
>
> (progn
> (setq last-coding-system-used 'prefer-utf-8-unix)
> (project-name (project-current))
> (message "%S" last-coding-system-used))
>
> prints "raw-text-unix" because it enables 'flyspell-mode'
> that calls:
>
> (defun ispell-buffer-local-parsing ()
> (ispell-send-string "!\n")
>
> where 'process-send-string' changes 'last-coding-system-used'
> to "raw-text-unix" in:
>
> send_process (Lisp_Object proc, const char *buf, ptrdiff_t len,
> Lisp_Object object)
> {
> ...
> Vlast_coding_system_used = CODING_ID_NAME (coding->id);
>
> A possible workaround would be to protect the value of
> last-coding-system-used in 'project-mode-line-format':
That's not a workaround, that's what we should do in such cases.
Alternatively, the "important" setting of last-coding-system-used
should be done later, after the inner functions already returned.
> However, I noticed that occasionally this bug occurs even
> when this function is not used. So the proper fix needed
> in 'basic-save-buffer', but I don't know if it's intended
> that some function should change 'last-coding-system-used'
> during saving the buffer.
Yes, it's intended: saving the buffer can change
buffer-file-coding-system if it detects characters which cannot be
encoded by the original buffer-file-coding-system.
next prev parent reply other threads:[~2023-10-29 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 18:40 bug#66825: last-coding-system-used in basic-save-buffer Juri Linkov
2023-10-29 19:27 ` Eli Zaretskii [this message]
2023-10-30 7:56 ` Juri Linkov
2023-10-30 12:15 ` Eli Zaretskii
2023-10-30 17:20 ` Juri Linkov
2023-10-30 17:45 ` Eli Zaretskii
2023-10-31 7:23 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8334xtb560.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66825@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.