From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded. Date: Wed, 06 Dec 2023 19:07:28 +0200 Message-ID: <8334wf45v3.fsf@gnu.org> References: <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org> <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org> <83plzj4jfk.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30053"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, luangruo@yahoo.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 06 18:08:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAvNX-0007PF-W4 for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Dec 2023 18:08:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAvMm-0004kD-MW; Wed, 06 Dec 2023 12:07:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAvMl-0004jx-6s for emacs-devel@gnu.org; Wed, 06 Dec 2023 12:07:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAvMk-0000Pa-A7; Wed, 06 Dec 2023 12:07:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sI5g6Nx6krYOoKkjQui+ecoENa5WkDg6ftFCF/y7Ar4=; b=Bjf9En5JY++e jPS5G1vbv6Vg44w36mJCrBCee8/61EwRD1Zh1gBmDCYZKC0iln+mM44x3W3WJVQj8Ma1WvBH1Lalb Cx/2VgUeyo6zDI6J8UuTxpxvafWw2osAJMCOyYlC/6egpfgt3sxg8YK+CcXoB90w0GEuo12zqPyRQ /DBAx7ItRDPBYMPKvmzC7zsu2OVoi0wS25W32kUHwFejTMHy3xZMo0Ih05mz/brnsDrsfxIZlnqo6 mzZ079iZ3MZ2OHPUGQU8T0vQG5iWL2qYrTJ5xEbFeZbaUA4CwDG82aU5DG4nfSniQi7Ijh9sPouFK fPjFvBIa7nFByGBKoBaJEw==; In-Reply-To: (message from Stefan Monnier on Wed, 06 Dec 2023 11:12:30 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313565 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org, luangruo@yahoo.com > Date: Wed, 06 Dec 2023 11:12:30 -0500 > > >> IOW, merge `insert-directory` and `ls-lisp--insert-directory` > >> by allowing `insert-directory-program` to be nil > >> (as a replacement for the `ls-lisp-use-insert-directory-program` > >> boolean) in which case we use the ls-lisp code? > > > > So if some Lisp program out there sets insert-directory-program to a > > non-nil value (probably intending to affect only Posix systems), Emacs > > on MS-Windows will suddenly start using it instead of ls-lisp? > > > > In general, IMO it's too late to make changes in this arrangement that > > would require users to switch to customizing a different user option. > > Then we can change the code to keep the same config vars but to change > `insert-directory` so it tests `ls-lisp-use-insert-directory-program` > and delegates to `ls-lisp` if non-nil, IOW hardcode the effect of > the advice. If that can be done safely and cleanly, yes. But then I wonder why we decided to use advice all those years ago...