From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Thu, 5 Sep 2019 11:18:46 +0000 (UTC) Message-ID: <833126594.1750522.1567682326940@mail.yahoo.com> References: <8acd9fc1-e6ce-9a86-cfb6-e00a672c154a@gmx.at> <20190901122628.aynhzwwpvqbgyydh@Ergus> <20190902110504.zniyfmd7bi53iyxe@Ergus> <83zhjm7juc.fsf@gnu.org> <4663e760-a611-6c29-e0e2-69bde9da87b1@gmx.at> <83tv9t77oq.fsf@gnu.org> <85658428-5253-6099-07b8-79831cf4e689@gmx.at> <83pnkh70d5.fsf@gnu.org> <81596d5c-427e-a95b-b66f-b571ac228ce1@gmx.at> <87pnkfsyhx.fsf@Ergus.i-did-not-set--mail-host-address--so-tickle-me> <2da98931-51d2-eb78-b79c-81323f95b4f6@gmx.at> <1826922767.1725310.1567682307734@mail.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1750521_429413597.1567682326938" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160956"; mail-complaints-to="usenet@blaine.gmane.org" Cc: eliz@gnu.org, emacs-devel@gnu.org To: rudalics@gmx.at Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 05 13:20:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5po7-000fh1-Iq for ged-emacs-devel@m.gmane.org; Thu, 05 Sep 2019 13:20:07 +0200 Original-Received: from localhost ([::1]:44694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5po6-0003AG-EZ for ged-emacs-devel@m.gmane.org; Thu, 05 Sep 2019 07:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50342) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5pn1-0002wJ-FT for emacs-devel@gnu.org; Thu, 05 Sep 2019 07:19:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5pmy-0003OV-Lm for emacs-devel@gnu.org; Thu, 05 Sep 2019 07:18:58 -0400 Original-Received: from sonic312-20.consmr.mail.bf2.yahoo.com ([74.6.128.82]:46817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5pmw-0003LC-2i for emacs-devel@gnu.org; Thu, 05 Sep 2019 07:18:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1567682329; bh=RysP6N9yUOVkY6PrFxvaz8XohKy+8s00WlQkATIQtLQ=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject; b=D8ymjnn0uQcTdM4unYTmgppoR/F4BtGl6BtCz/0FlIGzp/CWRItFxLXiv9kHdAqyEqH/lLbonHlaxKlugVoPdt8BdIdUL92Th6t9CVkrGgJXkgdX3zxU8UXugo71XIdaut6gyyfIUvFx3ahLDbB5FI4VK8SLjNGr2fBOEJ/9wrF4wtdDd0t8lTvrpM6L9v419+eHvoQuVC/rmicULQAnvhwchdkuynW2g2MtQboNSaq5CCYCjdTf4+l/0/57Ka6ykxp1HDPAo4RsGS9tqVqpJ+lUiSBmGDOSZIXCA1k0jWrGSbf3fnEbdqrrIR5KMywuzdtF3fRq360B9sUS0RpE1g== X-YMail-OSG: 39xHEbsVM1l_BOC5PxjDTKYN6dsGTH4jFqohnFoUYraufdUVP_meK3YCZwr23mG S8kOx4Fz19hn71mjI4JQ2SW974Ubrk.SncPXRDZiJLnOWOU2Fb7p3Cy1IX_jo8C.15MTPkKSNASw Np037QJRPnwKkAJp4h15nepsbMDV1jiESrWlDV1jl3M1Xt2Fe71LhvUHza_DCbeRwsm9rAJfAiCP EJmGA7SW5tlPwzUNeBDLYaaJPvtkIyEw68sonl1G4o20Jmq2MhRvRfATijA9MxE.kczBvGBaB9fX EF5.BdaCnVt8h.4ZzJbDpljq1qF8cetGzs1RmpohUnoDTYFISYW.2RNG.jbOwmK8JOBLI5xgCmze 2rXieatiMwvU6nrx4Bx5h5oStPSWoubrm45L6Ffka.wIeBM4g8dnb3_IZn8iEK1_Bn0AlNSIgDL3 xQg17ppHeokNNCSfEaWcXVtnlUNEmm6q81PVig.j_fohqVw8O1Fq__.xUTH4sjLhpZUO_1dZR8dz .re7iTXmmNWGm7aesNAXrOmgeiQBRZUVLOhxyvLTgqvaDQL6l7FnyTUpLSpmZvgKvLS68TZVcfKf BRo9XOqqr3Y_l4Wnckrjl_E3dMVagv0w9xlbzz0WaE_1LxRDYQMAUSYsYrgI93P_HEDFUlMXWeLa FY7.IhtA3V14J8dJKG_N.nNw3JGiNkpQwt44I7wvgpOClK2drb0Onbv7ue53n.7lOvbT0ClOL.Hz HMGtkWoZVnfuJbpNfWMWGFFHniuWXBCT_Jtctg1F9oJNU2iBb2ITqoNDLk5fXGrSC5N_X2EOE282 Zddp7WWq6EX2pZCW0pxV0p194uvgrzCNpoayw861BD Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Thu, 5 Sep 2019 11:18:49 +0000 In-Reply-To: <1826922767.1725310.1567682307734@mail.yahoo.com> X-Mailer: WebService/1.1.14303 aolwebmail Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 74.6.128.82 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239866 Archived-At: ------=_Part_1750521_429413597.1567682326938 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi again: I was just checking the code once again and it is actually working. Theprob= lem before was in the lisp part. the interactive functions: (set-face-extend 'region t) does not change the face value when called interactively. (We haveobserved = similar issues before with customize-variable and maybe itneeds to be fix.)= They seem to be changing the values of the variableslocally in the minibuf= fer instead of the "caller" buffer. But it workswhen executed throw C-x C-e= ; so maybe some lisper can give a look tothis please. As now it works at least for the region and fixes these issues. 1) Tui and gui extension is consistent (still needs some work but shouldbe = a minor issues to fix) 2) the region extension can be customized (which could be considered anew f= eature). 3) The interaction with dfci reported in the bug that started this isnot br= oken anymore. At the end I implemented it lazily because it appeared to be the easiestalt= ernative for me; but I am completely open to any comment/suggestion(please = ignore code style for now.) Finally I have a explicit question: when we set :extend nil for the region face do you consider correct thatthe= extra space we always add must have the region color (instead of thedefaul= t) in order to seea colored space in the empty lines? -----Original Message----- From: martin rudalics To: Ergus Cc: Eli Zaretskii ; emacs-devel Sent: Wed, Sep 4, 2019 10:34 pm Subject: Re: Question about display engine > I have just uploaded some changes but the functionality is still not > working. > > I separated the changes in 3 commits and in the last one are only the > ones I made in the xdisp.c (the ones that need to be checked, because > the rest is only infrastructure.) > > see the master branch in: https://github.com/Ergus/Emacs Please send a patch for current master.=C2=A0 Otherwise I have no idea how to compare your changes. Thanks, martin ------=_Part_1750521_429413597.1567682326938 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi again:

I was just checking the code once again and it is actually working. The
problem before was in the lisp part. the interactive functions:

(set-face-extend 'region t)

does not change the face value when called interactively. (We have
observed similar issues before with customize-variable and maybe it
needs to be fix.) They seem to be changing the values of the variables
locally in the minibuffer instead of the "caller" buffer. But it works
when executed throw C-x C-e; so maybe some lisper can give a look to
this please.

As now it works at least for the region and fixes these issues.

1) Tui and gui extension is consistent (still needs some work but should
be a minor issues to fix)

2) the region extension can be customized (which could be considered a
new feature).

3) The interaction with dfci reported in the bug that started this is
not broken anymore.

At the end I implemented it lazily because it appeared to be the easiest
alternative for me; but I am completely open to any comment/suggestion
(please ignore code style for now.)

Finally I have a explicit question:

when we set :extend nil for the region face do you consider correct that
the extra space we always add must have the region color (instead of the
default) in order to see
a colored space in the empty lines?




-----Original Message-----
From: martin rudalics <rudalics@gmx.at>
To: Ergus <spacibba@aol.com>
Cc: Eli Zaretskii <eliz@gnu.org>; emacs-devel <emacs-devel@gnu.org>
Sent: Wed, Sep 4, 2019 10:34 pm
Subject: Re: Question about display engine

> I have just uploaded some changes but the functionality is still not
> working.
>
> I separated the changes in 3 commits and in the last one are only the
> ones I made in the xdisp.c (the ones that need to be checked, because
> the rest is only infrastructure.)
>
> see the master branch in: https://github.com/Ergus/Emacs


Please send a patch for current master.  Otherwise I have no idea how
to compare your changes.

Thanks, martin


------=_Part_1750521_429413597.1567682326938--