bug#8013: 23.2.93; png not available

bug#8013: 23.2.93; png not available

[Uday S Reddy]

(image-type-availablep 'png) returns nil.  In the same environment,
Emacs 23.2 and 23.2.91 return t.  But 23.2.92 and 23.2.93 are returning
nil. 

My installation has GnuWin32's libpng library.  Here is a listing of the
directory:

  c:/GnuWin32/lib:
  total used in directory 621 available 659656
  drwxrwxrwx  1 udr None      0 01-30 19:06 .
  drwxrwxrwx  1 udr None      0 01-30 18:48 ..
  -rw-rw-rw-  1 udr None  12800 2005-05-15  jpeg-bcc.lib
  -rw-rw-rw-  1 udr None   3568 2005-05-15  jpeg.def
  -rw-rw-rw-  1 udr None  24220 2005-05-15  jpeg.lib
  -rw-rw-rw-  1 udr None  64620 2005-05-15  libjpeg.dll.a
  -rw-rw-rw-  1 udr None  29696 2009-06-04  libpng-bcc.lib
  -rw-rw-rw-  1 udr None 148640 2009-06-04  libpng.dll.a
  -rw-rw-rw-  1 udr None    995 01-30 19:05 libpng.la
  -rw-rw-rw-  1 udr None  51878 2009-06-04  libpng.lib
  -rw-rw-rw-  1 udr None   4645 2009-06-04  libpng12.def
  -rw-rw-rw-  1 udr None 148706 2009-06-04  libpng12.dll.a
  -rw-rw-rw-  1 udr None    995 01-30 19:05 libpng12.la
  -rw-rw-rw-  1 udr None  77534 2005-07-20  libz.a
  -rw-rw-rw-  1 udr None  43738 2005-07-20  libz.dll.a
  drwxrwxrwx  1 udr None      0 01-30 19:05 pkgconfig
  -rw-rw-rw-  1 udr None   6656 2005-07-20  zlib-bcc.lib
  -rw-rw-rw-  1 udr None   1868 2005-07-20  zlib.def
  -rw-rw-rw-  1 udr None  14778 2005-07-20  zlib.lib

Cheers,
Uday
-------


In GNU Emacs 23.2.93.1 (i386-mingw-nt5.1.2600)
 of 2011-02-01 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: VM Presentation

Minor modes in effect:
  shell-dirtrack-mode: t
  savehist-mode: t
  which-function-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  use-hard-newlines: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  line-number-mode: t
  visual-line-mode: t
  transient-mark-mode: t

Recent input:
c d c d c d c d c d c d c d c d c d d d d d d d c c 
d c d <switch-frame> <down-mouse-1> <mouse-1> <escape> 
. i m a g e - f s f e m a c s - 2 1 <return> <escape> 
: ( v m - i m a g e - t y p e - a v a i l a b l e - 
p SPC ' p n g ) <return> <escape> : <up> C-e C-b C-b 
C-b C-b C-d C-d C-d j p e g <return> <switch-frame> 
c c c c c c C-x c <return> c c c c SPC SPC SPC <backspace> 
C-l C-x o C-l M-v M-v M-v M-v C-v C-v C-v C-p D <switch-frame> 
<down-mouse-1> <mouse-1> <escape> . <return> <escape> 
. f o <backspace> r o b - i m a g e <return> C-l C-l 
C-x b v m . SPC o SPC <return> C-p C-p C-p C-f C-f 
C-f C-f C-f <escape> . <return> <help-echo> <help-echo> 
<down-mouse-1> <mouse-movement> <mouse-1> ` C-; C-9 
u C-x u C-x u <escape> : <up> <return> <down-mouse-1> 
<mouse-1> <switch-frame> <down-mouse-1> <mouse-movement> 
<mouse-1> <f1> g M-x v m - q u i t <return> g M-n M-n 
M-n SPC SPC SPC SPC s c o n f e r e n c e s . m <return> 
p SPC SPC SPC <down-mouse-1> <mouse-1> <down-mouse-3> 
<down-mouse-1> <mouse-1> <down-mouse-1> <mouse-1> <down-mouse-2> 
<mouse-2> <down-mouse-1> <mouse-1> <wheel-up> <double-wheel-up> 
<wheel-down> <wheel-up> <double-wheel-up> D D SPC SPC 
SPC SPC D p n p n Q y M-x v m <return> <f1> M-n M-n 
SPC p n Q M-x v m <return> n <down-mouse-1> <mouse-1> 
M-x r e p o r t - e m SPC SPC b SPC <return>

Recent messages:
Generating summary... 0
Sorting messages... done
Generating summary... 0
Sorting messages... done
Expunging messages in cache... 
Sorting messages... done
Expunging messages in cache... done
6761 messages, 7 new, 764 unread, 11 deleted [2 times]
Decoding MIME message... done
Making completion list...

Load-path shadows:
d:/Home/udr/share/emacs/sml-mode hides d:/gnu/emacs-23.2.93/../site-lisp/sml-mode
d:/Home/udr/share/emacs/savehist-20+ hides d:/gnu/emacs-23.2.93/../site-lisp/savehist-20+
d:/gnu/emacs-23.2.93/../site-lisp/longlines hides d:/gnu/emacs-23.2.93/lisp/longlines
d:/Home/udr/share/emacs/rnews hides d:/gnu/emacs-23.2.93/lisp/obsolete/rnews

Features:
(shadow sort message ecomplete mml mml-sec password-cache mm-decode
mm-bodies mm-encode mailcap nnheader gmm-utils mailheader canlock
hashcash emacsbug org-wl org-w3m org-vm org-rmail org-mhe org-mew
org-irc org-jsinfo org-infojs org-html org-exp org-exp-blocks org-agenda
org-info org-gnus org-bibtex org-bbdb org byte-opt warnings bytecomp
byte-compile org-footnote org-src org-list org-faces org-compat org-macs
noutline outline texinfo cus-edit cus-start cus-load debug cl-specs
edebug pp mule-util vm-mark ediff-merg ediff-diff ediff-wind ediff-help
ediff-util ediff-mult ediff-init ediff vc vc-dispatcher make-mode
ansi-color shell multi-isearch help-mode view info smtpmail flyspell
ispell newcomment mail-utils mailalias vm-reply longlines easy-mmode
vm-delete bbdb-hooks mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums
mm-util mail-prsvr w3m-form w3m browse-url doc-view dired-x dired-aux
mydired dired image-mode w3m-hist w3m-fb w3m-ems wid-edit w3m-ccl ccl
w3m-favicon w3m-image w3m-proc w3m-util vm-w3m vm-pop tapestry vm-sort
vm-thread vm-crypto vm-imap easymenu vc-bzr sha1 hex-util etags my-vm
ps-print ps-def lpr vm-save vm-ps-print vm-rfaddons vm-menu vm-window
vm-toolbar vm-folder vm-mime vm-undo vm-virtual vm-summary-faces
vm-mouse vm-page vm-minibuf vm-message vm-misc vm-macro bbdb-vm vm-vars
vm-summary vm-motion vm-autoload bbdb-snarf mail-extr rfc822 bbdb-com
advice help-fns advice-preload mailabbrev cl cl-19 vm-version vm server
w3m-load bbdb-autoloads bbdb timezone vm-autoloads savehist tex-site
tex-mik telnet movement natural-space NatSpeak sendmail auth-source
gnus-util netrc time-date epa-file epa epg epg-config ange-ftp
regexp-opt comint ring echistory chistory ehelp electric derived
which-func imenu edmacro kmacro jka-compr tooltip ediff-hook vc-hooks
lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win w32-vars
tool-bar dnd fontset image fringe lisp-mode register page menu-bar
rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process multi-tty emacs)

-- 

bug#8013: 23.2.93; png not available

[Eli Zaretskii]

> From: Uday S Reddy <u.s.reddy@cs.bham.ac.uk>
> Date: Thu, 10 Feb 2011 15:21:45 +0000
> Cc: U.S.Reddy@cs.bham.ac.uk
> 
> (image-type-available-p 'png) returns nil.  In the same environment,
> Emacs 23.2 and 23.2.91 return t.  But 23.2.92 and 23.2.93 are returning
> nil. 

What is your value of libpng-version?  I'd guess it's 10400 or some
such, which means you will need to install a newer version of libpng.
See this portion of README.W32:

    PNG: requires the PNG reference library 1.4 or later, which will
    be named libpng14.dll or libpng14-14.dll.  LibPNG requires zlib,
    which should come from the same source as you got libpng.
    Starting with Emacs 23.3, the precompiled Emacs binaries are
    built with libpng 1.4.x and later, and are incompatible with
    earlier versions of libpng DLLs.  So if you have libpng 1.2.x,
    the PNG support will not work, and you will have to download
    newer versions.

The latest pre-compiled binaries don't support versions of libpng
older than 1.4.0.

bug#8013: 23.2.93; png not available

[Uday S Reddy]

The libpng package I have installed is 1.2.37, which is the latest
version available on GnuWin32.

  http://gnuwin32.sourceforge.net/packages.html

libpng-version in Emacs is 10403.  So, it doesn't fit the bill.

Sean Sieger's pre-compiled Emacs distribution that I downloaded
doesn't seem to have the README.W32 file.  So, it has gone missing
somewhere.

I also wonder if it would be useful to provide diagnostic information
about package support somehow, e.g., with an optional argument to
image-type-available-p which prints diagnostic information.

Cheers,
Uday

bug#8013: 23.2.93; png not available

[Eli Zaretskii]

> Date: Fri, 11 Feb 2011 11:20:03 +0000
> From: Uday S Reddy <u.s.reddy@cs.bham.ac.uk>
> Cc: Uday S Reddy <u.s.reddy@cs.bham.ac.uk>,
>     8013@debbugs.gnu.org
> 
> The libpng package I have installed is 1.2.37, which is the latest
> version available on GnuWin32.
> 
>   http://gnuwin32.sourceforge.net/packages.html

You can find a newer one here:

   http://www.gtk.org/download-windows.html

The reason we switched to newer versions is that the old ones had
security problems.  Unfortunately, the new ones and the old ones are
incompatible in their interfaces, so we cannot use both.

> Sean Sieger's pre-compiled Emacs distribution that I downloaded
> doesn't seem to have the README.W32 file.  So, it has gone missing
> somewhere.

Sean, could you please fix this for the next pretest and the upcoming
release?

> I also wonder if it would be useful to provide diagnostic information
> about package support somehow, e.g., with an optional argument to
> image-type-available-p which prints diagnostic information.

Patches are welcome.

I'm closing the bug report.

bug#8013: 23.2.93; png not available

[Glenn Morris]

Eli Zaretskii wrote:

>> Sean Sieger's pre-compiled Emacs distribution that I downloaded
>> doesn't seem to have the README.W32 file.  So, it has gone missing
>> somewhere.
>
> Sean, could you please fix this for the next pretest and the upcoming
> release?

This file sits in the admin/ directory in emacs-23. Has it ever been
included in the distribution? Eg make-dist in the trunk explicitly
excludes it. I thought it was only supposed to go in

ftp://ftp.gnu.org/gnu/emacs/windows/

bug#8013: 23.2.93; png not available

[Glenn Morris]

Ignore me, I was mixing it up with a different file.

bug#8013: 23.2.93; png not available

[Sean Sieger]

Eli Zaretskii <eliz@gnu.org> writes:

    Sean, could you please fix this for the next pretest and the upcoming
    release?

Yes.

bug#8013: 23.2.93; png not available

[Lennart Borgman]

On Fri, Feb 11, 2011 at 1:15 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 11 Feb 2011 11:20:03 +0000
>> From: Uday S Reddy <u.s.reddy@cs.bham.ac.uk>
>> Cc: Uday S Reddy <u.s.reddy@cs.bham.ac.uk>,
>>     8013@debbugs.gnu.org
>>
>> The libpng package I have installed is 1.2.37, which is the latest
>> version available on GnuWin32.
>>
>>   http://gnuwin32.sourceforge.net/packages.html
>
> You can find a newer one here:
>
>   http://www.gtk.org/download-windows.html

Just to check: It is only libpng14-14.dll we need now, or?

bug#8013: 23.2.93; png not available

[Jason Rumney]

Glenn Morris <rgm@gnu.org> writes:

> Eli Zaretskii wrote:
>
>>> Sean Sieger's pre-compiled Emacs distribution that I downloaded
>>> doesn't seem to have the README.W32 file.  So, it has gone missing
>>> somewhere.
>>
>> Sean, could you please fix this for the next pretest and the upcoming
>> release?
>
> This file sits in the admin/ directory in emacs-23. Has it ever been
> included in the distribution? Eg make-dist in the trunk explicitly
> excludes it. I thought it was only supposed to go in
>
> ftp://ftp.gnu.org/gnu/emacs/windows/

The old script for building the Emacs windows binaries used to copy it
into the tree before zipping.  This script was changed to a makefile
rule recently, so this step is probably missing.

bug#8013: 23.2.93; png not available

[Jason Rumney]

Lennart Borgman <lennart.borgman@gmail.com> writes:
>
> Just to check: It is only libpng14-14.dll we need now, or?

You'll still need zlib for PNG images.  But if you get GTK, it should
include all dependencies for the image libraries it supports (all except
svg and imagemagik, I think).

bug#8013: 23.2.93; png not available

[Christoph]

On 2/11/2011 7:49 PM, Jason Rumney wrote:

> The old script for building the Emacs windows binaries used to copy it
> into the tree before zipping.  This script was changed to a makefile
> rule recently, so this step is probably missing.

The emacs24 weekly build contains the README.W32 file.

 From makefile.w32 in nt/:

dist: install-bin
	mkdir $(TMP_DIST_DIR)
	$(CP) "$(INSTALL_DIR)/BUGS" $(TMP_DIST_DIR)
	$(CP) "$(INSTALL_DIR)/COPYING" $(TMP_DIST_DIR)
	$(CP) "$(INSTALL_DIR)/README" $(TMP_DIST_DIR)
	$(CP) "$(INSTALL_DIR)/README.W32" $(TMP_DIST_DIR)
[...]

I guess there is a discrepancy with the pretests because only the trunk 
contains the new make rule. After I submitted it for the trunk it was 
decided that it was not necessary to backport it to the emacs23 branch, 
so Sean must be using the old script (or some manual way) to build the 
distribution for the pretests.

Christoph