From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#8664: Being more-systematic about user-interface timestamps Date: Fri, 13 May 2011 11:53:37 +0300 Message-ID: <831v03gewe.fsf@gnu.org> References: <4DCC3BD6.3000200@cs.ucla.edu> <4DCC425E.2070608@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1305276913 5868 80.91.229.12 (13 May 2011 08:55:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 13 May 2011 08:55:13 +0000 (UTC) Cc: 8664@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 13 10:55:07 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QKo9L-0005Mw-9v for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 May 2011 10:55:07 +0200 Original-Received: from localhost ([::1]:49028 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKo9K-0006Og-V4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 May 2011 04:55:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKo9I-0006Ni-Av for bug-gnu-emacs@gnu.org; Fri, 13 May 2011 04:55:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QKo9G-0005UM-UB for bug-gnu-emacs@gnu.org; Fri, 13 May 2011 04:55:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKo9G-0005UI-RV for bug-gnu-emacs@gnu.org; Fri, 13 May 2011 04:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QKo9F-000548-VA; Fri, 13 May 2011 04:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 May 2011 08:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8664 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8664-submit@debbugs.gnu.org id=B8664.130527688719453 (code B ref 8664); Fri, 13 May 2011 08:55:01 +0000 Original-Received: (at 8664) by debbugs.gnu.org; 13 May 2011 08:54:47 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QKo91-00053h-E3 for submit@debbugs.gnu.org; Fri, 13 May 2011 04:54:47 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QKo8x-00053R-R8 for 8664@debbugs.gnu.org; Fri, 13 May 2011 04:54:45 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LL400C00M0JSP00@a-mtaout22.012.net.il> for 8664@debbugs.gnu.org; Fri, 13 May 2011 11:54:07 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.91.65]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LL400C8TM24SG10@a-mtaout22.012.net.il>; Fri, 13 May 2011 11:54:07 +0300 (IDT) In-reply-to: <4DCC425E.2070608@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 13 May 2011 04:55:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46444 Archived-At: > Date: Thu, 12 May 2011 13:26:06 -0700 > From: Paul Eggert > > --- src/systime.h 2011-03-11 20:24:09 +0000 > +++ src/systime.h 2011-05-12 17:07:49 +0000 > @@ -30,6 +30,12 @@ > #endif > #endif > > +#ifdef HAVE_X_WINDOWS > +# include > +#else > +typedef unsigned long Time; > +#endif Wouldn't this clash with the typedef in w32gui.h? > --- src/menu.c 2011-05-12 06:48:32 +0000 > +++ src/menu.c 2011-05-12 16:55:07 +0000 > @@ -1147,13 +1147,13 @@ > #else /* not HAVE_X_WINDOWS */ > Lisp_Object bar_window; > enum scroll_bar_part part; > - unsigned long time; > + Time time; > void (*mouse_position_hook) (struct frame **, int, > Lisp_Object *, > enum scroll_bar_part *, > Lisp_Object *, > Lisp_Object *, > - unsigned long *) = > + Time *) = This needs a corresponding change in all the functions used as mouse_position_hook on different platforms. You made such a change only in 2 of them: term_mouse_position and XTmouse_position.