From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: mail-add-attachment Date: Sat, 10 Sep 2011 11:32:11 +0300 Message-ID: <831uvo6bn8.fsf@gnu.org> References: <838vq60wm6.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1315643600 19566 80.91.229.12 (10 Sep 2011 08:33:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 10 Sep 2011 08:33:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 10 10:33:16 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R2Izx-0002Yd-5N for ged-emacs-devel@m.gmane.org; Sat, 10 Sep 2011 10:33:13 +0200 Original-Received: from localhost ([::1]:60606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2Izw-0001RZ-5K for ged-emacs-devel@m.gmane.org; Sat, 10 Sep 2011 04:33:12 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:43782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2Izu-0001RR-8m for emacs-devel@gnu.org; Sat, 10 Sep 2011 04:33:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R2Izt-0008QD-8k for emacs-devel@gnu.org; Sat, 10 Sep 2011 04:33:10 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:55577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2Izs-0008Q6-WE for emacs-devel@gnu.org; Sat, 10 Sep 2011 04:33:09 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LRA00D00SXLVC00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Sat, 10 Sep 2011 11:32:12 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.9.62]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LRA00D7XT1NYV00@a-mtaout21.012.net.il>; Sat, 10 Sep 2011 11:32:12 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:143841 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Fri, 09 Sep 2011 10:32:19 -0400 > > > Is it okay to install this command at this time? I know we're in a > > feature freeze, but the new command is actually a very thin wrapper > > around code we already use elsewhere (gnus-dired.el and mml.el). The > > result will be that users of sendmail.el will be able to send MIME > > attachments. Here's the patch: > > I guess it could be OK. Thanks, committed as revision 105699 on the trunk. > > +(autoload 'mm-default-file-encoding "mm-encode" > > + "Return the default encoding for FILE.") > > I must say I don't like such manually-managed autoloads. I added autoload cookies to the relevant Gnus files instead, per the suggestion by Andreas. > > +\\[mail-attach-file] insert a text file into the message. > > +\\[mail-add-attachment] add to the message a file as a MIME attachment. > > I think mail-attach-file needs to be renamed to mail-insert-file. Done.