From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: mail-add-attachment
Date: Sat, 10 Sep 2011 11:32:11 +0300 [thread overview]
Message-ID: <831uvo6bn8.fsf@gnu.org> (raw)
In-Reply-To: <jwv4o0liyh9.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Fri, 09 Sep 2011 10:32:19 -0400
>
> > Is it okay to install this command at this time? I know we're in a
> > feature freeze, but the new command is actually a very thin wrapper
> > around code we already use elsewhere (gnus-dired.el and mml.el). The
> > result will be that users of sendmail.el will be able to send MIME
> > attachments. Here's the patch:
>
> I guess it could be OK.
Thanks, committed as revision 105699 on the trunk.
> > +(autoload 'mm-default-file-encoding "mm-encode"
> > + "Return the default encoding for FILE.")
>
> I must say I don't like such manually-managed autoloads.
I added autoload cookies to the relevant Gnus files instead, per the
suggestion by Andreas.
> > +\\[mail-attach-file] insert a text file into the message.
> > +\\[mail-add-attachment] add to the message a file as a MIME attachment.
>
> I think mail-attach-file needs to be renamed to mail-insert-file.
Done.
prev parent reply other threads:[~2011-09-10 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 10:05 mail-add-attachment Eli Zaretskii
2011-09-03 10:33 ` mail-add-attachment Andreas Schwab
2011-09-03 11:38 ` mail-add-attachment Eli Zaretskii
2011-09-03 11:54 ` mail-add-attachment Eli Zaretskii
2011-09-03 18:36 ` mail-add-attachment Chong Yidong
2011-09-08 16:38 ` mail-add-attachment Eli Zaretskii
2011-09-09 14:32 ` mail-add-attachment Stefan Monnier
2011-09-09 15:04 ` mail-add-attachment Eli Zaretskii
2011-09-09 16:15 ` mail-add-attachment Lars Magne Ingebrigtsen
2011-09-09 21:49 ` mail-add-attachment Stefan Monnier
2011-09-10 0:02 ` mail-add-attachment Lars Magne Ingebrigtsen
2011-09-10 1:40 ` mail-add-attachment Stefan Monnier
2011-09-10 8:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831uvo6bn8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.