From: Eli Zaretskii <eliz@gnu.org>
To: rudalics@gmx.at, claudio.bley@gmail.com, lekktu@gmail.com
Cc: 9087@debbugs.gnu.org
Subject: bug#9087: Crash reading from minibuffer with icomplete-mode
Date: Fri, 06 Jan 2012 22:50:30 +0200 [thread overview]
Message-ID: <831urco8rt.fsf@gnu.org> (raw)
In-Reply-To: <8362goobf6.fsf@gnu.org>
> Date: Fri, 06 Jan 2012 21:53:17 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: claudio.bley@gmail.com, lekktu@gmail.com, 9087@debbugs.gnu.org
>
> > Date: Fri, 06 Jan 2012 20:45:03 +0100
> > From: martin rudalics <rudalics@gmx.at>
> > CC: lekktu@gmail.com, claudio.bley@gmail.com, 9087@debbugs.gnu.org
> >
> > > If you meant this:
> > >
> > > emacs -Q --eval "(setq debug-on-quit t)" -l triggerbug.el
> > >
> > > then it doesn't help.
> >
> > I added
> >
> > (setq debug-on-quit t)
> >
> > to triggerbug.el, visit that file with emacs -Q, invoke
> > `emacs-lisp-byte-compile-and-load', and hit a key while I read "now!".
>
> I see the reason why I couldn't reproduce this: it is only
> reproducible with a byte-compiled triggerbug.elc. I initially tried
> with triggerbug.el.
I can avoid the crash with the patch below. But it defers the
throwing until Emacs is done whatever it was doing (in this case,
evaluating byte code). Is this acceptable? If not, what can we do to
make the throwing more "immediate"?
Claudio, can you see if this patch gives good results with
ido-find-file?
And why in the world isn't throw-on-input described in the ELisp
manual???
=== modified file 'src/w32fns.c'
--- src/w32fns.c 2012-01-05 09:46:05 +0000
+++ src/w32fns.c 2012-01-06 20:33:25 +0000
@@ -2479,6 +2479,7 @@ signal_user_input (void)
if (!NILP (Vthrow_on_input))
{
Vquit_flag = Vthrow_on_input;
+#if 0
/* If we're inside a function that wants immediate quits,
do it now. */
if (immediate_quit && NILP (Vinhibit_quit))
@@ -2486,6 +2487,7 @@ signal_user_input (void)
immediate_quit = 0;
QUIT;
}
+#endif
}
}
next prev parent reply other threads:[~2012-01-06 20:50 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 22:54 bug#9087: Crash reading from minibuffer with icomplete-mode Juanma Barranquero
2011-07-15 7:30 ` martin rudalics
2011-07-15 12:12 ` Juanma Barranquero
2011-07-15 12:23 ` martin rudalics
2011-07-15 16:40 ` Juanma Barranquero
2011-07-15 11:13 ` Eli Zaretskii
2011-07-15 12:11 ` Juanma Barranquero
2011-07-15 12:15 ` Juanma Barranquero
2011-07-15 12:29 ` Eli Zaretskii
2011-07-15 15:12 ` Juanma Barranquero
2011-07-15 15:24 ` Eli Zaretskii
2011-07-15 16:39 ` Juanma Barranquero
2011-07-15 17:12 ` Eli Zaretskii
2011-07-16 23:19 ` Juanma Barranquero
2011-07-17 3:08 ` Eli Zaretskii
2011-07-18 2:07 ` Juanma Barranquero
2011-07-18 3:01 ` Eli Zaretskii
2011-07-18 11:53 ` Juanma Barranquero
2011-07-18 16:45 ` Eli Zaretskii
2011-07-18 17:34 ` Juanma Barranquero
2011-07-17 9:38 ` martin rudalics
2011-07-18 1:59 ` Juanma Barranquero
2011-08-14 20:13 ` Chong Yidong
2011-09-14 14:43 ` Juanma Barranquero
2012-01-01 20:56 ` Claudio Bley
2012-01-01 21:24 ` Juanma Barranquero
2012-01-01 21:43 ` Eli Zaretskii
2012-01-02 16:16 ` Claudio Bley
2012-01-04 15:44 ` Claudio Bley
2012-01-06 10:02 ` Eli Zaretskii
2012-01-06 12:48 ` Juanma Barranquero
2012-01-06 13:19 ` martin rudalics
2012-01-06 13:26 ` Juanma Barranquero
2012-01-06 15:17 ` Eli Zaretskii
2012-01-06 16:07 ` martin rudalics
2012-01-06 19:01 ` Eli Zaretskii
2012-01-06 19:45 ` martin rudalics
2012-01-06 19:53 ` Eli Zaretskii
2012-01-06 20:50 ` Eli Zaretskii [this message]
2012-01-06 22:34 ` Juanma Barranquero
2012-01-07 0:42 ` Stefan Monnier
2012-01-07 8:31 ` Eli Zaretskii
2012-01-07 10:11 ` martin rudalics
2012-01-07 10:49 ` Eli Zaretskii
2012-01-07 11:51 ` martin rudalics
2012-01-07 12:21 ` Eli Zaretskii
2012-01-07 13:57 ` martin rudalics
2012-01-07 14:59 ` Eli Zaretskii
2012-01-07 16:27 ` martin rudalics
2012-01-07 17:05 ` Eli Zaretskii
2012-01-07 17:17 ` martin rudalics
2012-01-07 17:31 ` Eli Zaretskii
2012-01-07 17:45 ` martin rudalics
2012-01-07 17:52 ` Eli Zaretskii
2012-01-07 13:12 ` Andreas Schwab
2012-01-07 13:57 ` martin rudalics
2012-01-07 15:00 ` Eli Zaretskii
2012-01-07 18:21 ` Stefan Monnier
2012-01-07 18:59 ` Eli Zaretskii
2012-01-08 14:01 ` Stefan Monnier
2012-01-14 20:16 ` Eli Zaretskii
2012-01-07 10:10 ` martin rudalics
2012-01-07 10:58 ` Eli Zaretskii
2012-01-07 11:52 ` martin rudalics
2012-01-07 12:11 ` Eli Zaretskii
2012-01-07 13:55 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831urco8rt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=9087@debbugs.gnu.org \
--cc=claudio.bley@gmail.com \
--cc=lekktu@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.