From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12316: Simplify redefinition of 'abort'. Date: Fri, 31 Aug 2012 17:29:02 +0300 Message-ID: <831uinqgnl.fsf@gnu.org> References: <50402C2B.5020800@cs.ucla.edu> <833933qohs.fsf@gnu.org> <5040B3BA.6070108@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1346423400 30089 80.91.229.3 (31 Aug 2012 14:30:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Aug 2012 14:30:00 +0000 (UTC) Cc: lekktu@gmail.com, 12316@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 31 16:29:59 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T7SEQ-0005BA-2V for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Aug 2012 16:29:58 +0200 Original-Received: from localhost ([::1]:56263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7SEN-0000VW-LH for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Aug 2012 10:29:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7SEL-0000VH-0p for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 10:29:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7SEF-0003zb-0f for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 10:29:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7SEE-0003zW-TI for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 10:29:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T7SFS-0002pW-7E for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Aug 2012 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12316 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12316-submit@debbugs.gnu.org id=B12316.134642343210838 (code B ref 12316); Fri, 31 Aug 2012 14:31:02 +0000 Original-Received: (at 12316) by debbugs.gnu.org; 31 Aug 2012 14:30:32 +0000 Original-Received: from localhost ([127.0.0.1]:59618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7SEx-0002ol-Lk for submit@debbugs.gnu.org; Fri, 31 Aug 2012 10:30:31 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:40670) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7SEv-0002od-GI for 12316@debbugs.gnu.org; Fri, 31 Aug 2012 10:30:31 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M9M00900IVJ4900@a-mtaout22.012.net.il> for 12316@debbugs.gnu.org; Fri, 31 Aug 2012 17:29:02 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M9M008RIIWEQU90@a-mtaout22.012.net.il>; Fri, 31 Aug 2012 17:29:02 +0300 (IDT) In-reply-to: <5040B3BA.6070108@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63629 Archived-At: > Date: Fri, 31 Aug 2012 05:53:14 -0700 > From: Paul Eggert > CC: 12316@debbugs.gnu.org, lekktu@gmail.com > > Due to the change, POSIX platforms define a function > emacs_abort rather than replacing the system 'abort'. But this is not equivalent to the old code: with your changes, only those calls to 'abort' that originate within Emacs sources will wind up at 'emacs_abort'. E.g., if a function from one of the libraries linked into Emacs, like the image libraries, calls 'abort', that will bypass our function. Why is it a good idea to lose this functionality? And if we do want to lose this, why not simply replace all the calls to 'abort' with calls to 'emacs_abort'? Isn't that cleaner? > To keep in sync with that, the MS-Windows part of the patch > renames w32_abort to emacs_abort. I don't see this part in your patches. Where is it? Without this, I cannot see how this will possibly work. > Also, this redefinition of 'abort' provides another > reason why conf_post.h must include , which makes > its comment about 'environ' confusing. To help remove this > confusion I modified nt/inc/unistd.h to include ; Please don't do that. A standard header should not include another standard header; I don't want our private emulations violate this rule, to avoid conflicts. Surely, there are better and more straight-forward ways of dealing with outdated comments.