From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Enhancement for file-attributes Date: Mon, 01 Oct 2012 14:59:00 +0200 Message-ID: <831uhicprf.fsf@gnu.org> References: <83a9w7egdd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1349096356 11194 80.91.229.3 (1 Oct 2012 12:59:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 12:59:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 01 14:59:22 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIfaf-0002WX-1s for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 14:59:17 +0200 Original-Received: from localhost ([::1]:55778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIfaZ-0006z3-GY for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 08:59:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIfaT-0006yl-35 for emacs-devel@gnu.org; Mon, 01 Oct 2012 08:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIfaJ-0001eF-Q7 for emacs-devel@gnu.org; Mon, 01 Oct 2012 08:59:05 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:44571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIfaJ-0001e5-Ht for emacs-devel@gnu.org; Mon, 01 Oct 2012 08:58:55 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MB700500TCZ1D00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Mon, 01 Oct 2012 14:58:53 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MB70042PTE5VX70@a-mtaout21.012.net.il>; Mon, 01 Oct 2012 14:58:53 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153821 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sun, 30 Sep 2012 21:16:31 -0400 > > > Would it be a good idea to enhance file-attributes by adding one more > > optional argument to it, which, when non-nil, will cause Emacs call > > 'stat', not 'lstat', on the argument file name? This should avoid the > > need to call file-chase-links when all we want is to get the > > attributes of the file pointed to by the symlink. > > It would have made a lot of sense originally, but I'm wondering whether > it's worth the trouble now. What trouble can this make? An additional argument whose default is nil should never cause any trouble. Am I missing something? > In how many places would we save the file-chase-links all? Are > these places important? One place is in files.el: after-find-file, when we visit a file that is a symlink, and backup-buffer. These are quite frequently used APIs.