From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Enhancement for file-attributes
Date: Mon, 01 Oct 2012 14:59:00 +0200 [thread overview]
Message-ID: <831uhicprf.fsf@gnu.org> (raw)
In-Reply-To: <jwvhaqf8031.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sun, 30 Sep 2012 21:16:31 -0400
>
> > Would it be a good idea to enhance file-attributes by adding one more
> > optional argument to it, which, when non-nil, will cause Emacs call
> > 'stat', not 'lstat', on the argument file name? This should avoid the
> > need to call file-chase-links when all we want is to get the
> > attributes of the file pointed to by the symlink.
>
> It would have made a lot of sense originally, but I'm wondering whether
> it's worth the trouble now.
What trouble can this make? An additional argument whose default is
nil should never cause any trouble. Am I missing something?
> In how many places would we save the file-chase-links all? Are
> these places important?
One place is in files.el: after-find-file, when we visit a file that
is a symlink, and backup-buffer. These are quite frequently used
APIs.
next prev parent reply other threads:[~2012-10-01 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 14:26 Enhancement for file-attributes Eli Zaretskii
2012-09-30 21:14 ` Paul Eggert
2012-09-30 22:08 ` Eli Zaretskii
2012-10-01 0:45 ` Stefan Monnier
2012-10-01 2:08 ` Paul Eggert
2012-10-08 10:36 ` Michael Albinus
2012-10-01 1:16 ` Stefan Monnier
2012-10-01 2:04 ` Juanma Barranquero
2012-10-01 12:59 ` Eli Zaretskii [this message]
2012-10-01 14:31 ` Stefan Monnier
2012-10-01 14:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831uhicprf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.