From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12811: 24.3.50; `scroll-up/down-aggressively' don't seem to work as expected Date: Tue, 06 Nov 2012 23:36:23 +0200 Message-ID: <831ug62z3c.fsf@gnu.org> References: <83ip9i3c59.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1352237817 5437 80.91.229.3 (6 Nov 2012 21:36:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2012 21:36:57 +0000 (UTC) Cc: 12811@debbugs.gnu.org To: Dani Moncayo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 06 22:37:06 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TVqpT-0003jJ-40 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2012 22:37:03 +0100 Original-Received: from localhost ([::1]:41060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVqpK-0007UR-7W for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2012 16:36:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVqpH-0007UC-8N for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2012 16:36:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TVqpG-0006Ab-3m for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2012 16:36:51 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVqpG-0006AW-06 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2012 16:36:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TVqsM-0000P9-6f for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2012 16:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2012 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12811 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12811-submit@debbugs.gnu.org id=B12811.13522379841529 (code B ref 12811); Tue, 06 Nov 2012 21:40:02 +0000 Original-Received: (at 12811) by debbugs.gnu.org; 6 Nov 2012 21:39:44 +0000 Original-Received: from localhost ([127.0.0.1]:52930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVqs4-0000Ob-IX for submit@debbugs.gnu.org; Tue, 06 Nov 2012 16:39:44 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:61424) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVqs2-0000OU-Ed for 12811@debbugs.gnu.org; Tue, 06 Nov 2012 16:39:43 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MD300H005B0WT00@a-mtaout23.012.net.il> for 12811@debbugs.gnu.org; Tue, 06 Nov 2012 23:36:28 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MD300HZZ5CORZ50@a-mtaout23.012.net.il>; Tue, 06 Nov 2012 23:36:25 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66557 Archived-At: > Date: Tue, 6 Nov 2012 20:18:30 +0100 > From: Dani Moncayo > Cc: 12811@debbugs.gnu.org > > So I'd like to make this request: > * Make obsolete the variables `scroll-up/down-aggressively'. > * Extend the semantics of the variable `scroll-step' to accept also a > fractional number between 0 and 1, so that for example 0.7 would mean: > "when point moves out, try to get it back into view by scrolling > up/down an amount equal to the 70% of the height of the window. If > that fails, center in the window the line where point is". Wouldn't this keep the same semantics, but in one variable instead of 3? Anyway, it's too late to make such changes now, because a year and a half so ago, there a was similar discussion about scroll-conservatively, and people who set it to a large value explicitly asked for that to work over large scrolls. So the code was restructured to support that (that's why it was so easy for me to fix this one); going back means a serious surgery on that code, which I think is unjustified at this point, as I didn't hear any complaints about scrolling for a long time. > It would not make sense, indeed, but according to the current > documentation, point should be positioned according to > `scroll-up/down-aggressively'. Well, now it does. > > That is why what you expected never worked in Emacs, at least since > > v21.1. The code which implements the effect of these variables was > > written under the assumption that point is only a small ways outside > > of the window, one or 2 screen lines, because this is what happens > > when you type "C-n" or "C-p" on the border of the scroll margin. > > But that assumption is false in many real-life cases. Not when you cause the scroll with C-n or C-p (without numeric arguments). Then it's true. > > Having said that, since the code already almost did TRT, it is much > > easier for me to fix it for this use case than to argue about the > > applicability of these variables. So I did just that in revision > > 110795 on the emacs-24 branch. > > Good, thanks. Then perhaps the documentation should be updated to > reflect this, no? What's wrong with the documentation now? The code does what it says, no?