all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@jurta.org>, Kenichi Handa <handa@gnu.org>
Cc: 13084@debbugs.gnu.org
Subject: bug#13084: boyer_moore crashes with certain characters in the case	table
Date: Tue, 11 Dec 2012 17:37:09 +0200	[thread overview]
Message-ID: <831uewa9cq.fsf@gnu.org> (raw)
In-Reply-To: <87txs1l4kg.fsf@mail.jurta.org>

> From: Juri Linkov <juri@jurta.org>
> Date: Wed, 05 Dec 2012 02:34:39 +0200
> 
> The minimal reproducible recipe for crashes in boyer_moore noticed in bug#13041:
> 
> 1. emacs -Q
> 
> 2. Eval in *scratch*:
> 
> (let ((table (standard-case-table)) canon)
>   (setq canon (copy-sequence table))
>   (aset canon #xff59 ?y)
>   (set-char-table-extra-slot table 1 canon)
>   (set-char-table-extra-slot table 2 nil)
>   (set-standard-case-table table))
> 
> 3. Start an activity that includes a search, e.g. `C-x 8 RET TAB'

Thanks.  I think i fixed this (revision 111021 on the emacs-24
branch), please test.

In addition, I'd suggest that Handa-san (or someone else) takes a good
look at the code that sets up the simple_translate table in
boyer_moore, because the constants there, like 0200 and 0x3F, and all
the talk about characters that belong "to the same charset and row"
smell of pre-Unicode (a.k.a. "MULE") representation of characters.
For now, I disabled boyer_moore for unibyte characters beyond 160,
because my reading of the code is that simple_translate and the
supporting code cannot handle that.  Maybe I'm wrong.





  reply	other threads:[~2012-12-11 15:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05  0:34 bug#13084: boyer_moore crashes with certain characters in the case table Juri Linkov
2012-12-11 15:37 ` Eli Zaretskii [this message]
2012-12-11 23:17   ` Juri Linkov
2012-12-12  3:55     ` Eli Zaretskii
2012-12-12  9:27       ` Juri Linkov
2012-12-12 10:21         ` martin rudalics
2012-12-12 10:31           ` Juri Linkov
2012-12-12 12:43             ` martin rudalics
2012-12-12 16:47         ` Eli Zaretskii
2012-12-12 23:05           ` Juri Linkov
2012-12-13 13:39   ` Kenichi Handa
2012-12-13 17:32     ` Eli Zaretskii
2012-12-15 13:17       ` Kenichi Handa
2012-12-15 13:55         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831uewa9cq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=13084@debbugs.gnu.org \
    --cc=handa@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.