From: Eli Zaretskii <eliz@gnu.org>
To: Shigeru Fukaya <shigeru.fukaya@gmail.com>
Cc: 13553-done@debbugs.gnu.org
Subject: bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP
Date: Sun, 27 Jan 2013 09:15:45 +0200 [thread overview]
Message-ID: <831ud7jdum.fsf@gnu.org> (raw)
In-Reply-To: <AFCDFC5B7DFA7Fshigeru.fukaya@gmail.com>
> From: Shigeru Fukaya <shigeru.fukaya@gmail.com>
> Cc: 13553@debbugs.gnu.org
> Date: Sun, 27 Jan 2013 15:56:54 +0900
>
> Built on migw32, and no trouble, thank you
> (I didn't do coverage tests, sorry).
Thanks. I'm therefore closing this bug.
> But we must remember, my raise of issue is the incorrect usage of
> IS_DIRECTORY_SEP. There are still more in fileio.c and more.
Yes. This is being discussed on emacs-devel, and once that discussion
ends, the fileio.c and dired.c functions will be fixed as well.
> >> As for coding symbol, not a few Japanese use 'cp932 not 'shift-jis I
> >> suppose. But we need some notice for users.
> >
> >Not sure what you are saying here. Do you think many Japanese Windows
> >users will set file-name-coding-system to shift_jis, or that most of
> >them will set it to cp932?
> >
> >Normally, users don't customize file-name-coding-system at all, in
> >which case Emacs will use default-file-name-coding-system, that is
> >automatically set to cp932, according to the system-wide codepage.
>
> Yes, you are right. I mean, maybe, the case of using some remote file
> system.
Accessing remote files doesn't go through functions in w32.c, it goes
through file handlers (in Tramp).
> You can check by yourself their (our?) usage if you like.
> Some seems still using shift-jis, not cp932.
>
> http://www.google.co.jp/search?q=file-name-coding-system+sjis
If they want 100% solid support, they will have to change their
customizations, sorry. (We could implement an equivalence table,
whereby, e.g., shift_jis would be mapped to cp932, but these encodings
are slightly different, so I think that would be a kludge.)
In any case, the new code in w32.c is no worse than the previous one,
when file-name-coding-system is set to anything that is not a
recognized Windows codepage. It is actually slightly better: it uses
the system-wide ANSI codepage in that case. In most cases, this would
be the right thing anyway.
prev parent reply other threads:[~2013-01-27 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 5:52 bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP Shigeru Fukaya
2013-01-26 10:26 ` Stefan Monnier
2013-01-26 11:16 ` Eli Zaretskii
2013-01-26 12:40 ` Stefan Monnier
2013-01-26 13:23 ` Eli Zaretskii
2013-01-26 22:24 ` Stefan Monnier
2013-01-27 7:06 ` Eli Zaretskii
2013-01-27 8:36 ` Shigeru Fukaya
2013-01-27 9:40 ` Eli Zaretskii
2013-01-26 12:56 ` Eli Zaretskii
2013-01-26 14:06 ` Eli Zaretskii
2013-01-26 16:33 ` Shigeru Fukaya
2013-01-26 17:37 ` Eli Zaretskii
2013-01-27 6:56 ` Shigeru Fukaya
2013-01-27 7:15 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831ud7jdum.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13553-done@debbugs.gnu.org \
--cc=shigeru.fukaya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.