From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2 1/5] w32: define new jpeglib-version var in order to load the correct DLL at runtime Date: Fri, 01 Nov 2013 11:16:16 +0200 Message-ID: <831u30cwin.fsf@gnu.org> References: <877gcvylnn.wl%claudio.bley@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1383297406 2014 80.91.229.3 (1 Nov 2013 09:16:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Nov 2013 09:16:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Claudio Bley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 01 10:16:49 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VcAqX-0003wk-6S for ged-emacs-devel@m.gmane.org; Fri, 01 Nov 2013 10:16:49 +0100 Original-Received: from localhost ([::1]:36778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcAqW-0005Lw-DV for ged-emacs-devel@m.gmane.org; Fri, 01 Nov 2013 05:16:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcAqM-0005LW-NX for emacs-devel@gnu.org; Fri, 01 Nov 2013 05:16:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VcAqG-0006J1-OG for emacs-devel@gnu.org; Fri, 01 Nov 2013 05:16:38 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:47170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcAqG-0006I6-FG for emacs-devel@gnu.org; Fri, 01 Nov 2013 05:16:32 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MVK00F00V28LY00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Fri, 01 Nov 2013 11:16:31 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVK00FY7V3I9J90@a-mtaout22.012.net.il>; Fri, 01 Nov 2013 11:16:31 +0200 (IST) In-reply-to: <877gcvylnn.wl%claudio.bley@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164785 Archived-At: > Date: Wed, 30 Oct 2013 13:43:08 +0100 > From: Claudio Bley > > All jpeglib versions from 7 to 9 are binary incompatible with earlier > ones. > --- > lisp/term/w32-win.el | 4 +++- > src/image.c | 14 ++++++++++++++ > 2 files changed, 17 insertions(+), 1 deletion(-) I installed this with minor changes: . renamed jpeglib-version to libjpeg-version, for consistency with other image libraries; . changed the comparison in w32-win.el to compare against 62, not 0, because jpeg6 does define JPEG_LIB_VERSION; the comparison says now (if (> libjpeg-version 62) . added a comment in w32-win.el explaining the reasons for the binary incompatibilities