From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Subject: read-event in batch mode
Date: Fri, 31 Jan 2014 13:48:12 +0200 [thread overview]
Message-ID: <831tzo74oz.fsf@gnu.org> (raw)
Currently, read-event waits forever when called in batch mode. This
is because of the following fragment from kbd_buffer_get_event:
#ifndef HAVE_DBUS /* We want to read D-Bus events in batch mode. */
if (noninteractive
/* In case we are running as a daemon, only do this before
detaching from the terminal. */
|| (IS_DAEMON && daemon_pipe[1] >= 0))
{
int c = getchar ();
XSETINT (obj, c);
*kbp = current_kboard;
return obj;
}
#endif /* ! HAVE_DBUS */
The call to getchar will wait indefinitely, until something is typed
on the keyboard.
Worse, if Emacs is built with D-Bus, this fragment is bypassed
(including if Emacs is run in daemon mode!), and then read-event does
honor the timeout. The net effect is that writing code that waits for
events and works on all platforms is tricky at best.
This was discovered while debugging the problems of
file-notify-tests.el, see bug #16519 for more details and context.
Does any port for a supported platform need this fragment, or can we
safely delete it? What about the daemon -- does it need this "when
detaching from the terminal", and if so, why?
In any case, I think we need to document this deviant behavior, at
least for now, because there's no hint of it anywhere in the docs. Of
course, sit-for is also affected by that.
Comments?
next reply other threads:[~2014-01-31 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 11:48 Eli Zaretskii [this message]
2014-01-31 13:43 ` read-event in batch mode Michael Albinus
2014-01-31 14:58 ` Eli Zaretskii
2014-01-31 15:34 ` Stefan Monnier
2014-01-31 16:16 ` Eli Zaretskii
2014-02-04 11:54 ` Michael Albinus
2014-02-04 15:57 ` Eli Zaretskii
2014-02-04 18:16 ` Stefan Monnier
2014-01-31 14:09 ` Stefan Monnier
2014-01-31 15:03 ` Eli Zaretskii
2014-02-02 12:11 ` Nix
2014-02-02 15:59 ` Eli Zaretskii
2014-02-02 19:25 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831tzo74oz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.