From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16448: 24.3; Messages from (error "...") with UTF-8 chars are printed wrongly in Emacs Lisp scripts Date: Sat, 01 Feb 2014 14:00:04 +0200 Message-ID: <831tzn59h7.fsf@gnu.org> References: <20140115111009.dc0d435fa9991c3e15816f84@gmail.com> <52D60869.1000206@yandex.ru> <83vbxl45rk.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1391256071 13797 80.91.229.3 (1 Feb 2014 12:01:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Feb 2014 12:01:11 +0000 (UTC) Cc: 16448-done@debbugs.gnu.org, dmantipov@yandex.ru To: stselikh@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 01 13:01:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W9ZG9-0004BQ-Uy for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Feb 2014 13:01:18 +0100 Original-Received: from localhost ([::1]:37138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9ZG9-0003dZ-7q for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Feb 2014 07:01:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9ZG0-0003Xw-6s for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2014 07:01:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9ZFu-0002tj-UT for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2014 07:01:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9ZFu-0002tb-RA for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2014 07:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W9ZFu-0000Gs-Js for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2014 07:01:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2014 12:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16448 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 16448@debbugs.gnu.org, eliz@gnu.org, stselikh@gmail.com Original-Received: via spool by 16448-done@debbugs.gnu.org id=D16448.1391256029994 (code D ref 16448); Sat, 01 Feb 2014 12:01:02 +0000 Original-Received: (at 16448-done) by debbugs.gnu.org; 1 Feb 2014 12:00:29 +0000 Original-Received: from localhost ([127.0.0.1]:43976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W9ZFM-0000Fy-GP for submit@debbugs.gnu.org; Sat, 01 Feb 2014 07:00:28 -0500 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:54319) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W9ZFH-0000Fl-6n for 16448-done@debbugs.gnu.org; Sat, 01 Feb 2014 07:00:24 -0500 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N0B00600FFD1200@mtaout29.012.net.il> for 16448-done@debbugs.gnu.org; Sat, 01 Feb 2014 14:02:01 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N0B00NVYG3DTMC0@mtaout29.012.net.il>; Sat, 01 Feb 2014 14:02:01 +0200 (IST) In-reply-to: <83vbxl45rk.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:84394 Archived-At: > Date: Wed, 15 Jan 2014 17:35:43 +0200 > From: Eli Zaretskii > Cc: 16448@debbugs.gnu.org, stselikh@gmail.com > > > Date: Wed, 15 Jan 2014 08:02:49 +0400 > > From: Dmitry Antipov > > Cc: 16448@debbugs.gnu.org > > > > On 01/15/2014 04:10 AM, Sergey Tselikh wrote: > > > > > In a script, when (error "...") instruction is executed with some UTF-8 > > > characters in its text, the message is not printed correctly. > > > > In batch mode, (error ...) is handled by external-debugging-output, and the > > latter just does: > > > > putc (XINT (character) & 0xFF, stderr); > > ^^^^^^ > > To allow multibyte sequences here, we should use something like: > > > > === modified file 'src/print.c' > > --- src/print.c 2014-01-01 07:43:34 +0000 > > +++ src/print.c 2014-01-15 03:55:39 +0000 > > @@ -709,8 +709,14 @@ > > to make it write to the debugging output. */) > > (Lisp_Object character) > > { > > + unsigned char str[MAX_MULTIBYTE_LENGTH]; > > + unsigned int ch; > > + ptrdiff_t len; > > + > > CHECK_NUMBER (character); > > - putc (XINT (character) & 0xFF, stderr); > > + ch = XINT (character); > > + len = CHAR_STRING (ch, str); > > + fwrite (str, len, 1, stderr); > > This will only work correctly in a UTF-8 locale. In the general case, > we need to run the resulting multibyte sequence through ENCODE_SYSTEM, > before writing it to stderr. Done in trunk revision 116232.